From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH storage] archive_info: use timelocal correctly
Date: Wed, 8 Jul 2020 10:50:34 +0200 [thread overview]
Message-ID: <16c260e9-ba83-813b-9607-485be0b06f49@proxmox.com> (raw)
In-Reply-To: <20200708082219.25439-1-f.ebner@proxmox.com>
On 08.07.20 10:22, Fabian Ebner wrote:
> Because we always have 4-digit years, we can simply pass
> the year itself to timelocal instead of subtracting 1900.
> Like this it will also work for years not in the range 2000-2999.
>
> See also:
> https://perldoc.perl.org/Time/Local.html#Year-Value-Interpretation
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Hopefully in 3070, Perl isn't full of surprises anymore.
>
> PVE/Storage.pm | 2 +-
> test/archive_info_test.pm | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 31 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-07-08 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:22 [pve-devel] " Fabian Ebner
2020-07-08 8:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c260e9-ba83-813b-9607-485be0b06f49@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox