From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH-SERIES qemu-server] migration: nbd alloc: improve format fallback
Date: Thu, 27 Jul 2023 10:29:15 +0200 [thread overview]
Message-ID: <1690446531.x6pzdc8mm2.astroid@yuna.none> (raw)
In-Reply-To: <20230717140020.74568-1-f.ebner@proxmox.com>
thanks! (once more for the list ;))
On July 17, 2023 4:00 pm, Fiona Ebner wrote:
> Currently, remote migration behaves a bit differently, because an
> explicitly passed-in format that is not supported by the target
> storage is not overwritten with the storage's default format.
>
> This meant remote live migration with qcow2 to e.g. LVM-thin would not
> work, because the code here wrongly tried to allocate a qcow2 disk.
>
> There also is a qemu_img_format() call which uses the target storage's
> $scfg and the source storage's volume name, which is not very nice
> either. Change that first and explain how it only affects certain edge
> cases and then clean up the whole mess by moving, getting the format
> hint to the call side for local migration too.
>
> Fiona Ebner (2):
> migration: alloc nbd disks: base format hint off source storage
> migration: alloc nbd disks: fix fall-back for remote live migration
>
> PVE/API2/Qemu.pm | 1 -
> PVE/QemuServer.pm | 32 +++++++++-----------------------
> 2 files changed, 9 insertions(+), 24 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2023-07-27 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:00 [pve-devel] " Fiona Ebner
2023-07-17 14:00 ` [pve-devel] [PATCH qemu-server 1/2] migration: alloc nbd disks: base format hint off source storage Fiona Ebner
2023-07-17 14:00 ` [pve-devel] [PATCH qemu-server 2/2] migration: alloc nbd disks: fix fall-back for remote live migration Fiona Ebner
2023-07-27 8:29 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1690446531.x6pzdc8mm2.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox