From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH manager] vzdump: included_guest: return empty hash if no guests selected
Date: Thu, 9 Jul 2020 13:34:39 +0200 [thread overview]
Message-ID: <1688b136-f023-48ac-da5d-14a795e7c285@proxmox.com> (raw)
In-Reply-To: <20200709112128.27030-1-a.lauterer@proxmox.com>
On 09.07.20 13:21, Aaron Lauterer wrote:
> This will fix the behaviour when calling `vzdump --stop` to cause all
> local guests to be backed up.
>
> When refactoring this logic in commit be308647, the assumption was that
> every call will have one of the following parameters set: pool, list of
> VMIDs or all (intentional or when exclude is used).
>
> There is an addtional possibility, that vzdump is called with only
> --stop. Thus there are no other parameters that would indicate which
> VMIDs to include.
>
> In this case we want to return the empty hash.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> PVE/VZDump.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-07-09 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 11:21 [pve-devel] " Aaron Lauterer
2020-07-09 11:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688b136-f023-48ac-da5d-14a795e7c285@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox