From: Friedrich Weber <f.weber@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] vm start: set minimum timeout of 300s if using PCI passthrough
Date: Fri, 8 Sep 2023 13:40:53 +0200 [thread overview]
Message-ID: <166ac5f2-30a7-7ae1-7b59-c6b39cf57bfa@proxmox.com> (raw)
In-Reply-To: <b7f629db-7689-c796-0f10-5175c49c0fd7@proxmox.com>
On 21/08/2023 10:33, Fiona Ebner wrote:
> Would it make sense to instead add a constant multiplier to the memory
> timeout heuristic in presence of PCI passthrough? The user says 65 GiB
> takes about 3 min 30 s, so assuming it's more or less linear, the 5 min
> from this patch would not be enough for more than ~130 GiB of memory.
You're right, a heuristic makes more sense here than a constant
multiplier. I'll give it a try in the next version.
>> Notes:
>> An alternative workaround is offered by an unapplied patch series [3]
>> of bug #3502 [2] that makes it possible to set VM-specific timeouts
>> (also in the GUI). Users could use this option to manually set a
>> higher timeout for VMs that use PCI passthrough. However, it is not
>> immediately obvious that a higher timeout is necessary. Since the
>> problem seems to come up somewhat frequently, I think it makes sense
>> to have the heuristic choose a higher timeout by default.
>>
>> [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502
>> [3]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055352.html
>
> Yes, I think having both the better heuristic and the configurable
> timeout makes sense. Since Daniel left, do you want to have another look
> at the series/pick it up?
Sure! When I'm back from vacation, I'll send another version of this
patch series and also take a look at Daniel's old patch series. I'll
probably send them separately though, as they are somewhat independent.
next prev parent reply other threads:[~2023-09-08 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 13:37 Friedrich Weber
2023-08-21 8:33 ` Fiona Ebner
2023-09-08 11:40 ` Friedrich Weber [this message]
2023-09-11 7:03 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166ac5f2-30a7-7ae1-7b59-c6b39cf57bfa@proxmox.com \
--to=f.weber@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox