public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix net regex in qm cleanup
Date: Wed, 21 Sep 2022 09:13:08 +0200	[thread overview]
Message-ID: <1663744382.cxi3rfyplh.astroid@nora.none> (raw)
In-Reply-To: <20220920145043.801188-1-d.csapak@proxmox.com>

On September 20, 2022 4:50 pm, Dominik Csapak wrote:
> the '+' needs to be in the brackets, otherwise '$1' is not the right id
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/CLI/qm.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index 6a2e161..ca5d25f 100755
> --- a/PVE/CLI/qm.pm
> +++ b/PVE/CLI/qm.pm
> @@ -809,7 +809,7 @@ __PACKAGE__->register_method({
>  		# we have to cleanup the tap devices after a crash
>  
>  		foreach my $opt (keys %$conf) {
> -		    next if $opt !~  m/^net(\d)+$/;
> +		    next if $opt !~  m/^net(\d+)$/;
>  		    my $interface = $1;
>  		    PVE::Network::tap_unplug("tap${vmid}i${interface}");
>  		}
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 




  reply	other threads:[~2022-09-21  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 14:50 [pve-devel] " Dominik Csapak
2022-09-21  7:13 ` Fabian Grünbichler [this message]
2022-09-21  7:58 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1663744382.cxi3rfyplh.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal