From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v2 storage 1/2] RBD plugin: librados connect: pass along options
Date: Tue, 13 Sep 2022 09:59:01 +0200 [thread overview]
Message-ID: <1663055931.ssh2tm832c.astroid@nora.none> (raw)
In-Reply-To: <20220902073307.31429-1-f.ebner@proxmox.com>
thanks!
On September 2, 2022 9:33 am, Fiona Ebner wrote:
> In preparation to increase the timeout for workers. Both existing
> callers of librados_connect() don't currently use the parameter.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> No changes from v1.
>
> PVE/Storage/RBDPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
> index eeeaf3f..0d6f596 100644
> --- a/PVE/Storage/RBDPlugin.pm
> +++ b/PVE/Storage/RBDPlugin.pm
> @@ -27,7 +27,7 @@ my $get_parent_image_name = sub {
> my $librados_connect = sub {
> my ($scfg, $storeid, $options) = @_;
>
> - my $librados_config = PVE::CephConfig::ceph_connect_option($scfg, $storeid);
> + my $librados_config = PVE::CephConfig::ceph_connect_option($scfg, $storeid, $options->%*);
>
> my $rados = PVE::RADOS->new(%$librados_config);
>
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-09-13 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 7:33 [pve-devel] " Fiona Ebner
2022-09-02 7:33 ` [pve-devel] [PATCH v2 storage 2/2] RBD plugin: librados connect: increase timeout when in worker Fiona Ebner
2022-09-13 7:59 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663055931.ssh2tm832c.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox