From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] fix #4189: pbs: bump list_volumes timeout to 2mins
Date: Wed, 17 Aug 2022 13:16:26 +0200 [thread overview]
Message-ID: <1660734978.ambik70l6h.astroid@nora.none> (raw)
In-Reply-To: <20220817103237.176084-1-w.bumiller@proxmox.com>
thanks!
On August 17, 2022 12:32 pm, Wolfgang Bumiller wrote:
> When switching this from calling the external binary to
> using the perl api client the timeout got reduced to 7
> seconds, which is definitely insufficient for larger stores.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> PVE/Storage/PBSPlugin.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
> index afc6ea4..603529f 100644
> --- a/PVE/Storage/PBSPlugin.pm
> +++ b/PVE/Storage/PBSPlugin.pm
> @@ -688,7 +688,7 @@ my sub snapshot_files_encrypted {
> # TODO: use a client with native rust/proxmox-backup bindings to profit from
> # API schema checks and types
> my sub pbs_api_connect {
> - my ($scfg, $password) = @_;
> + my ($scfg, $password, $timeout) = @_;
>
> my $params = {};
>
> @@ -709,7 +709,7 @@ my sub pbs_api_connect {
> %$params,
> host => $scfg->{server},
> port => $scfg->{port} // 8007,
> - timeout => 7, # cope with a 401 (3s api delay) and high latency
> + timeout => ($timeout // 7), # cope with a 401 (3s api delay) and high latency
> cookie_name => 'PBSAuthCookie',
> );
>
> @@ -724,7 +724,7 @@ sub list_volumes {
> return $res if !grep { $_ eq 'backup' } @$content_types;
>
> my $password = pbs_get_password($scfg, $storeid);
> - my $conn = pbs_api_connect($scfg, $password);
> + my $conn = pbs_api_connect($scfg, $password, 120);
> my $datastore = $scfg->{datastore};
>
> my $param = {};
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-08-17 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 10:32 [pve-devel] " Wolfgang Bumiller
2022-08-17 11:16 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660734978.ambik70l6h.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox