From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v2 manager/guest-common] replication: improve removal of stale snapshots/volumes
Date: Tue, 02 Aug 2022 11:08:27 +0200 [thread overview]
Message-ID: <1659431219.7qhji1l67l.astroid@nora.none> (raw)
In-Reply-To: <ba299e48-3250-a948-c6d7-6e1a01e1087e@proxmox.com>
including RFC patch, which looked sensible to me ;)
thanks!
On July 27, 2022 1:22 pm, Fiona Ebner wrote:
> Am 13.06.22 um 12:29 schrieb Fabian Ebner:
>> In certain scenarios, see manager 2/2 and guest-common 3/4, replicated
>> volumes could end up orphaned. This series attempts to fix those, as
>> well as making removal of stale replication snaphsots a bit more
>> robust. Also includes some slight documentation improvements regarding
>> prepare().
>>
>
> Ping
>
>> v1 can be found here (but there was no discussion):
>> https://lists.proxmox.com/pipermail/pve-devel/2020-October/045388.html
>>
>> Changes from v1:
>> * Adapt to changed behavior of prepare(), so we still only catch
>> volumes that had replication snapshots belonging to the job.
>> * Drop simplification that would only rely on replication state
>> to get storages for full removal.
>> * Add safe-guard to only remove other replication snaphsots if the
>> last_sync snapshot is present.
>>
>>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-08-02 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 10:29 [pve-devel] " Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 manager 1/2] pvesr: rename last_snapshots to local_snapshots Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 manager 2/2] pvesr: prepare local job: remove stale replicated volumes immediately Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 1/4] replication: prepare: adapt/expand function comment Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 2/4] replication: rename last_snapshots to local_snapshots Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [PATCH v2 guest-common 3/4] replication: also consider storages from replication state upon removal Fabian Ebner
2022-06-13 10:29 ` [pve-devel] [RFC v2 guest-common 4/4] replication: prepare: safeguard against removal if expected snapshot is missing Fabian Ebner
2022-07-27 11:22 ` [pve-devel] [PATCH-SERIES v2 manager/guest-common] replication: improve removal of stale snapshots/volumes Fiona Ebner
2022-08-02 9:08 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1659431219.7qhji1l67l.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox