public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] MooseFS storage plugin
Date: Tue, 19 Apr 2022 12:14:20 +0200	[thread overview]
Message-ID: <1650362772.zl3kfo8mc2.astroid@nora.none> (raw)
In-Reply-To: <mailman.322.1650334562.377.pve-devel@lists.proxmox.com>

On April 19, 2022 4:15 am, Benjamin via pve-devel wrote:
> I've hacked together a really basic first try.
> 
> https://github.com/Zorlin/pve-moosefs/blob/main/MooseFSPlugin.pm
> 
> I'm getting this error which I don't fully understand -
> 
> Can't locate object method "mkpath" via package "/mnt/mfs" (perhaps you
> forgot to load "/mnt/mfs"?) at
> /usr/share/perl5/PVE/Storage/Custom/MooseFSPlugin.pm line 111. (500)

the current state seems to be basically equivalent to the following 
(which doesn't require a custom plugin ;)):
- ensure moosefs gets mounted (.mount unit, fstab, ..) at boot
- dir plugin entry with is_mountpoint set

the first part is handled by activate_storage in your plugin, the second 
part makes the dir plugin only active (or activatable) if something is 
mounted at the configured path (otherwise, failure to mount the moosefs 
would lead to using the local empty mountpoint dir, which is of course 
not desired!)

might be an avenue worth exploring if all the interaction between PVE 
and the storage besides the storage activation itself is via dir 
semantics/the dir plugin code ;) of course if there are more aspects 
that do require interacting with the moosefs server when doing certain 
storage operations, a custom plugin is the way to go (with all the 
caveats Thomas already mentioned).




      parent reply	other threads:[~2022-04-19 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.321.1650311387.377.pve-devel@lists.proxmox.com>
     [not found] ` <CAGwEZW+ZM+OQ311gRfeK2x5secP-2qSKwUZ3i78dWJMqq1qkAg@mail.gmail.com>
2022-04-19  8:13   ` Thomas Lamprecht
     [not found] ` <mailman.322.1650334562.377.pve-devel@lists.proxmox.com>
2022-04-19 10:14   ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650362772.zl3kfo8mc2.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal