From: Laurent GUERBY <laurent@guerby.net>
To: Matthias Heiserer <m.heiserer@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] New API endpoint to manage snippets / bugzilla 2208 / updated patch but missing something, need help
Date: Mon, 11 Apr 2022 12:00:05 +0200 [thread overview]
Message-ID: <1649671205.6346.35.camel@guerby.net> (raw)
In-Reply-To: <9881cc3c-e316-2f8d-2be4-cb36e3161045@proxmox.com>
On Mon, 2022-04-11 at 11:03 +0200, Matthias Heiserer wrote:
> Hi,
>
> please take a look at our developer documentation.
> https://pve.proxmox.com/wiki/Developer_Documentation
>
> Using `git format-patch` makes applying the changes a whole lot
> easier :)
>
> As far as I can tell from a quick test, your changes seem to work.
> Would you mind using `pvesh create` to test?
>
> If it doesn't work there either, make sure to include the exact
> command/code you used so people can try to reproduce the problem.
>
Hi,
Thanks for the pointer I'll give it a spin later this week.
I opened a bugzilla on the "501" error since I'm able to reproduce the
"upload small file" bug on an unmodified PVE 7:
https://bugzilla.proxmox.com/show_bug.cgi?id=3990
Since snippets yaml are likely to be small they'll be impacted by this
prior bug.
Sincerely,
Laurent
prev parent reply other threads:[~2022-04-11 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 10:27 [pve-devel] New API endpoint to manage snippets Patryk Ściborek
2022-04-08 9:06 ` [pve-devel] New API endpoint to manage snippets / bugzilla 2208 / updated patch but missing something, need help Laurent GUERBY
2022-04-08 18:25 ` Laurent GUERBY
2022-04-11 9:03 ` Matthias Heiserer
2022-04-11 10:00 ` Laurent GUERBY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649671205.6346.35.camel@guerby.net \
--to=laurent@guerby.net \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox