From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES] move jobs from pve-manager
Date: Fri, 08 Apr 2022 09:44:35 +0200 [thread overview]
Message-ID: <1649403675.3sjssov72n.astroid@nora.none> (raw)
In-Reply-To: <20220322073412.30562-1-h.laimer@proxmox.com>
On March 22, 2022 8:34 am, Hannes Laimer wrote:
> The VZDump plugin was moved to pve-guest-common because it is used by
> both CTs and VMs. Since the Jobs.pm contains helpers that depend on the
> VZDump plugin, it was also moved to pve-guest-common. The base jobs
> plugin was moved to pve-cluster since it does not really depend on
> anything and might be used in many places.
>
> Version bumps are needed.
actually (although it's pretty obvious in this case given the
description above and the diff stats below ;):
version bumps, versioned dependencies and breaks+replaces since files
are moved from one package to another while keeping their paths!
pve-manager depends on bumped pve-cluster and bumped pve-guest-common (using moved files)
pve-guest-common depends on bumped pve-cluster (using moved files)
pve-guest-common breaks & replaces old pve-manager (taking over files)
pve-cluster breaks & replaces old pve-manager (taking over file)
replace pve-cluster with new binary package possibly (see patch #1)
but alas, this requires some more work/thought anyway - see patch #2.
>
> pve-cluster:
>
> Hannes Laimer (1):
> jobs: move base plugin from pve-manager
>
> data/PVE/Jobs/Makefile | 11 ++++
> data/PVE/Jobs/Plugin.pm | 101 +++++++++++++++++++++++++++++++++++++
> data/PVE/Makefile | 2 +-
> debian/pve-cluster.install | 1 +
> 4 files changed, 114 insertions(+), 1 deletion(-)
> create mode 100644 data/PVE/Jobs/Makefile
> create mode 100644 data/PVE/Jobs/Plugin.pm
>
>
> pve-guest-common:
>
> Hannes Laimer (1):
> jobs: move VZDump plugin from pve-manager
>
> src/Makefile | 4 +
> src/PVE/Jobs.pm | 282 +++++++++++++++++++++++++++++++++++++++++
> src/PVE/Jobs/VZDump.pm | 87 +++++++++++++
> 3 files changed, 373 insertions(+)
> create mode 100644 src/PVE/Jobs.pm
> create mode 100644 src/PVE/Jobs/VZDump.pm
>
>
> pve-manager:
>
> Hannes Laimer (1):
> jobs: move to pve-cluster and pve-guest-common
>
> PVE/Jobs.pm | 282 ---------------------------------------------
> PVE/Jobs/Makefile | 16 ---
> PVE/Jobs/Plugin.pm | 101 ----------------
> PVE/Jobs/VZDump.pm | 87 --------------
> PVE/Makefile | 3 +-
> 5 files changed, 1 insertion(+), 488 deletions(-)
> delete mode 100644 PVE/Jobs.pm
> delete mode 100644 PVE/Jobs/Makefile
> delete mode 100644 PVE/Jobs/Plugin.pm
> delete mode 100644 PVE/Jobs/VZDump.pm
>
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-04-08 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 7:34 Hannes Laimer
2022-03-22 7:34 ` [pve-devel] [PATCH pve-cluster 1/3] jobs: move base plugin " Hannes Laimer
[not found] ` <<20220322073412.30562-2-h.laimer@proxmox.com>
2022-04-08 7:40 ` Fabian Grünbichler
2022-03-22 7:34 ` [pve-devel] [PATCH pve-guest-common 2/3] jobs: move VZDump " Hannes Laimer
2022-04-08 7:40 ` Fabian Grünbichler
2022-03-22 7:34 ` [pve-devel] [PATCH pve-manager 3/3] jobs: move to pve-cluster and pve-guest-common Hannes Laimer
2022-04-08 7:44 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649403675.3sjssov72n.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox