From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] partially-applied: [PATCH-SERIES v2 storage/manager/guest-common/docs] improvements for protected backups
Date: Wed, 06 Apr 2022 14:10:16 +0200 [thread overview]
Message-ID: <1649246943.cvi1zlor86.astroid@nora.none> (raw)
In-Reply-To: <20220329125324.120737-1-f.ebner@proxmox.com>
pve-storage (+bump)
first part of series regarding counting protected + small follow-up
discussed off-list
second part with note templates requires a re-send for {{VAR}} syntax.
On March 29, 2022 2:53 pm, Fabian Ebner wrote:
> The series consists of two parts:
>
> First part (up to docs 2/2) is for introducing a storage property
> to limit the number of protected backups and only count unprotected
> backups for the limit check in vzdump. This is useful to still be able
> to limit the amount of backups a user can make, because protected
> backups are not considered when pruning, and a user with backup
> privilege could mark their new backups as protected each time.
>
> Second part introduces 'protected' and a 'notes-template' option to
> generate notes from a template string with certain variables for
> vzdump, and adds them for manual backup and backup jobs in the UI.
>
>
> Changes from v1:
> * Add some rationale to the cover letter.
> * Drop already applied patch.
> * Default to unlimited for privileged users. I also dropped the
> patch to dynamically set the property upon storage creation in
> the UI, because the default itself is more dynamic now.
> * Switch to a template string for notes, supporting certain
> variables.
>
>
> Previous discussion here:
> https://lists.proxmox.com/pipermail/pve-devel/2021-December/051214.html
>
>
> storage:
>
> Fabian Ebner (1):
> plugins: allow limiting the number of protected backups per guest
>
> PVE/Storage.pm | 35 ++++++++++++++++++++++++++++++++++
> PVE/Storage/BTRFSPlugin.pm | 3 ++-
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/CephFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/GlusterfsPlugin.pm | 1 +
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/PBSPlugin.pm | 1 +
> PVE/Storage/Plugin.pm | 7 +++++++
> 9 files changed, 50 insertions(+), 1 deletion(-)
>
>
> manager:
>
> Fabian Ebner (8):
> vzdump: backup file list: drop unused parameter
> vzdump: backup limit: only count unprotected backups
> ui: storage edit: retention: add max-protected-backups setting
> vzdump: support setting protected status
> partially close #438: vzdump: support setting notes-template
> ui: backup: allow setting protected and notes-template for manual
> backup
> close #438: ui: backup job: allow setting a notes-template for a job
> ui: backup job: set guest name as default notes-template
>
> PVE/VZDump.pm | 89 +++++++++++++++++++++-------
> www/manager6/dc/Backup.js | 18 ++++++
> www/manager6/panel/BackupJobPrune.js | 47 ++++++++++++---
> www/manager6/storage/Base.js | 1 +
> www/manager6/window/Backup.js | 25 +++++++-
> 5 files changed, 147 insertions(+), 33 deletions(-)
>
>
> docs:
>
> Fabian Ebner (2):
> storage: switch to prune-backups in examples
> vzdump/storage: mention protected backups limit and give an example
>
> pve-storage-dir.adoc | 9 +++++----
> pve-storage-pbs.adoc | 2 +-
> vzdump.adoc | 5 +++++
> 3 files changed, 11 insertions(+), 5 deletions(-)
>
>
> guest-common:
>
> Fabian Ebner (1):
> vzdump: schema: add 'notes-template' and 'protected' properties
>
> src/PVE/VZDump/Common.pm | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-04-06 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 12:53 [pve-devel] " Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 storage 1/1] plugins: allow limiting the number of protected backups per guest Fabian Ebner
2022-04-06 10:42 ` [pve-devel] applied: " Fabian Grünbichler
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 1/8] vzdump: backup file list: drop unused parameter Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 2/8] vzdump: backup limit: only count unprotected backups Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [RFC v2 manager 3/8] ui: storage edit: retention: add max-protected-backups setting Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 docs 1/2] storage: switch to prune-backups in examples Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 docs 2/2] vzdump/storage: mention protected backups limit and give an example Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 guest-common 1/1] vzdump: schema: add 'notes-template' and 'protected' properties Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 4/8] vzdump: support setting protected status Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 5/8] partially close #438: vzdump: support setting notes-template Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 6/8] ui: backup: allow setting protected and notes-template for manual backup Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 7/8] close #438: ui: backup job: allow setting a notes-template for a job Fabian Ebner
2022-03-29 12:53 ` [pve-devel] [PATCH v2 manager 8/8] ui: backup job: set guest name as default notes-template Fabian Ebner
2022-04-06 12:10 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649246943.cvi1zlor86.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox