From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH kernel-helper/manager v3] check for fitting grub-meta package on uefi systems
Date: Mon, 6 Nov 2023 18:13:43 +0100 [thread overview]
Message-ID: <1645ee1d-6682-478d-8772-6c10b5c80aa2@proxmox.com> (raw)
In-Reply-To: <20231011132342.55518-1-s.ivanov@proxmox.com>
Am 11/10/2023 um 15:23 schrieb Stoiko Ivanov:
> v2->v3:
> * adapted Friedrich's feedback (huge thanks for the patience and attention
> to semantically important details!!) - so that the pve7to8 warning is
> actually understandable
>
> v1->v2:
> * adapted Friedrich's feedback (huge thanks!)
> ** fixed the wrongly negated check for installed grub-efi-amd64 in the
> boot-tool hook.
> ** Rephrased the error-message in pve7to8 to 2 sentences. I tried adding a
> newline as well, however this results in the message not being printed
> in the warning color anymore (most likely due to [0]) - and I felt this
> to be more important than having it on a separate line.
>
> [0] https://perldoc.perl.org/Term::ANSIColor#RESTRICTIONS
>
> original cover-letter for v1:
> The following patchset is a followup to the one for the installer:
> https://lists.proxmox.com/pipermail/pve-devel/2023-September/059270.html
>
> As suggested by Thomas - adding the check to proxmox-kernel-helper seems
> like a good idea. While adding it to d/postinst I thought that this might
> not be the best place - and that getting the warning upon every
> kernel-upgrade would be better vs. upon every upgrade of
> proxmox-kernel-helper (which are far less often).
> (Can gladly send the version with d/postinst as well)
>
> If the pve-manager patch gets applied - I'd push the equivalent change to
> pmg and provide one for pbs.
>
> Tested on legacy and uefi VMs installed with pve-8.0 iso and
> grub-efi-amd64 (and systemd-boot) removed vs. installed.
>
> proxmox-kernel-helper
> Stoiko Ivanov (2):
> proxmox-boot-tool: do not exit early in kernel-hook
> proxmox-boot-tool: check if correct grub metapackage is installed
>
> src/proxmox-boot/zz-proxmox-boot | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> pve-manager:
> Stoiko Ivanov (1):
> pve7to8: check for proper grub meta-package for bootmode
>
> PVE/CLI/pve7to8.pm | 39 +++++++++++++++++++++++----------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
applied, with Friedrich's R-b/T-b tags, thanks!
I did some rewording for the kernel-helper, aligning it a bit more with the
one from pve6to7
prev parent reply other threads:[~2023-11-06 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 13:23 [pve-devel] " Stoiko Ivanov
2023-10-11 13:23 ` [pve-devel] [PATCH kernel-helper v3 1/2] proxmox-boot-tool: do not exit early in kernel-hook Stoiko Ivanov
2023-10-11 13:23 ` [pve-devel] [PATCH kernel-helper v3 2/2] proxmox-boot-tool: check if correct grub metapackage is installed Stoiko Ivanov
2023-10-11 13:23 ` [pve-devel] [PATCH manager v3 1/1] pve7to8: check for proper grub meta-package for bootmode Stoiko Ivanov
2023-10-11 14:39 ` [pve-devel] [PATCH kernel-helper/manager v3] check for fitting grub-meta package on uefi systems Friedrich Weber
2023-11-06 17:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1645ee1d-6682-478d-8772-6c10b5c80aa2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox