Re: [pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf endpoint

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On January 18, 2022 9:35 am, Fabian Ebner wrote:
> Am 17.01.22 um 16:38 schrieb Fabian Grünbichler:
>> missing a reason why this is added to the generic node index, and not
>> somewhere under qemu?
>>
> 
> I suppose because having it under /nodes/{node}/qemu/ would imply having 
> it under /nodes/{node}/qemu/{vmid}/ (as we don't support having both 
> path/{regex} and path/static at the same time), but it doesn't depend on 
> any vmid?

ack, that makes sense, and now that you mention it I remember having 
this exact discussion back when the CPU model stuff was introduced ;)

> 
> 
>> On January 13, 2022 11:08 am, Fabian Ebner wrote:
>>> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
>>> [split into its own patch + add to index]
>>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>>> ---
>>>
>>> Needs dependency bump for qemu-server.
>>>
>>> Changes from v9:
>>>      * Add entry to /node/'s index.
>>>
>>>   PVE/API2/Nodes.pm | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
>>> index d57a1937..5f6208d5 100644
>>> --- a/PVE/API2/Nodes.pm
>>> +++ b/PVE/API2/Nodes.pm
>>> @@ -49,6 +49,7 @@ use PVE::API2::LXC;
>>>   use PVE::API2::Network;
>>>   use PVE::API2::NodeConfig;
>>>   use PVE::API2::Qemu::CPU;
>>> +use PVE::API2::Qemu::OVF;
>>>   use PVE::API2::Qemu;
>>>   use PVE::API2::Replication;
>>>   use PVE::API2::Services;
>>> @@ -71,6 +72,11 @@ __PACKAGE__->register_method ({
>>>       path => 'qemu',
>>>   });
>>>   
>>> +__PACKAGE__->register_method ({
>>> +    subclass => "PVE::API2::Qemu::OVF",
>>> +    path => 'readovf',
>>> +});
>>> +
>>>   __PACKAGE__->register_method ({
>>>       subclass => "PVE::API2::LXC",
>>>       path => 'lxc',
>>> @@ -233,6 +239,7 @@ __PACKAGE__->register_method ({
>>>   	    { name => 'network' },
>>>   	    { name => 'qemu' },
>>>   	    { name => 'query-url-metadata' },
>>> +	    { name => 'readovf' },
>>>   	    { name => 'replication' },
>>>   	    { name => 'report' },
>>>   	    { name => 'rrd' }, # fixme: remove?
>>> -- 
>>> 2.30.2
>>>
>>>
>>>
>>> _______________________________________________
>>> pve-devel mailing list
>>> pve-devel@lists.proxmox.com
>>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>>
>> 
>> 
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>