Re: [pve-devel] [PATCH-SERIES v5 manager/common/storage] fix #1710: add download from url button

[Dominik Csapak <d.csapak@proxmox.com>]

api side LGTM and it works like advertised, some coding issues on
the last patch, i'll answer there separately

On 5/12/21 10:22, Lorenz Stechauner wrote:
> changes to v4:
> reworked check_file_hash
> small fixes: typos, default values, etc.
> 
> patches:
> 1 - manager: add query_url_metadata method
> 2 - common: add download_file_from_url
> 3 - manager: refactor aplinfo to use common download function
> 4 - storage: add download_url method
> 5 - manager: add HashAlgorithmSelector
> 6 - manager: change download task format
> 7 - manager: fix #1710: add download from url button
> 
> 
> pve-manager:
> Lorenz Stechauner (5):
>    api: nodes: add query_url_metadata method
>    api: nodes: refactor aplinfo to use common download function
>    ui: add HashAlgorithmSelector
>    ui: Utils: change download task format
>    fix #1710: ui: storage: add download from url button
> 
>   PVE/API2/Nodes.pm                          | 159 +++++++-----
>   www/manager6/Makefile                      |   1 +
>   www/manager6/Utils.js                      |   2 +-
>   www/manager6/form/HashAlgorithmSelector.js |  16 ++
>   www/manager6/storage/Browser.js            |   8 +
>   www/manager6/storage/ContentView.js        | 282 +++++++++++++++++++--
>   6 files changed, 376 insertions(+), 92 deletions(-)
>   create mode 100644 www/manager6/form/HashAlgorithmSelector.js
> 
> 
> pve-common:
> Lorenz Stechauner (1):
>    tools: add download_file_from_url
> 
>   src/PVE/Tools.pm | 124 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 124 insertions(+)
> 
> 
> pve-storage
> Lorenz Stechauner (1):
>    status: add download_url method
> 
>   PVE/API2/Storage/Status.pm | 118 +++++++++++++++++++++++++++++++++++--
>   PVE/Storage.pm             |  10 ++++
>   2 files changed, 123 insertions(+), 5 deletions(-)
>