From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC zfsonlinux 5/5] bump libzpool soname
Date: Wed, 08 Sep 2021 13:51:18 +0200 [thread overview]
Message-ID: <1631101569.c2kwj78so3.astroid@nora.none> (raw)
In-Reply-To: <20210907131755.1016175-6-s.ivanov@proxmox.com>
On September 7, 2021 3:17 pm, Stoiko Ivanov wrote:
> following commit ec311430e2fd66492498a1559f56ef25e1192266 upstream
>
> However since libzfs increased both the current as well as the age
> the soname of the library remained at libzfs4.so - following
> https://www.debian.org/doc/debian-policy/ch-sharedlibs.html
> I left the package name at libzfs4linux
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Makefile | 2 +-
> debian/control | 12 ++++++------
> debian/{libzpool4linux.docs => libzpool5linux.docs} | 0
> ...ol4linux.install.in => libzpool5linux.install.in} | 0
> ...an-overrides => libzpool5linux.lintian-overrides} | 0
> 5 files changed, 7 insertions(+), 7 deletions(-)
> rename debian/{libzpool4linux.docs => libzpool5linux.docs} (100%)
> rename debian/{libzpool4linux.install.in => libzpool5linux.install.in} (100%)
> rename debian/{libzpool4linux.lintian-overrides => libzpool5linux.lintian-overrides} (100%)
>
> diff --git a/Makefile b/Makefile
> index a6eeca09..3113001a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -13,7 +13,7 @@ libpam-zfs_${ZFSPKGVER}_amd64.deb \
> libuutil3linux_${ZFSPKGVER}_amd64.deb \
> libzfs4linux_${ZFSPKGVER}_amd64.deb \
> libzfsbootenv1linux_${ZFSPKGVER}_amd64.deb \
> -libzpool4linux_${ZFSPKGVER}_amd64.deb \
> +libzpool5linux_${ZFSPKGVER}_amd64.deb \
> zfs-test_${ZFSPKGVER}_amd64.deb \
> zfsutils-linux_${ZFSPKGVER}_amd64.deb \
> zfs-zed_${ZFSPKGVER}_amd64.deb
> diff --git a/debian/control b/debian/control
> index 168dfb91..b17e643d 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -70,7 +70,7 @@ Depends: libssl-dev | libssl1.0-dev,
> libuutil3linux (= ${binary:Version}),
> libzfs4linux (= ${binary:Version}),
> libzfsbootenv1linux (= ${binary:Version}),
> - libzpool4linux (= ${binary:Version}),
> + libzpool5linux (= ${binary:Version}),
> ${misc:Depends}
> Provides: libnvpair-dev, libuutil-dev
> Description: OpenZFS filesystem development files for Linux
> @@ -78,7 +78,7 @@ Description: OpenZFS filesystem development files for Linux
> libraries of OpenZFS filesystem.
> .
> This package includes the development files of libnvpair3, libuutil3,
> - libzpool4 and libzfs4.
> + libzpool5 and libzfs4, libzfsbootenv1.
>
> Package: libzfs4linux
> Section: contrib/libs
> @@ -106,12 +106,12 @@ Description: OpenZFS filesystem library for Linux
> .
> The zfsbootenv library provides support for modifying ZFS label information.
>
> -Package: libzpool4linux
> +Package: libzpool5linux
> Section: contrib/libs
> Architecture: linux-any
> Depends: ${misc:Depends}, ${shlibs:Depends}
> -Breaks: libzpool2, libzpool2linux, libzpool3linux, libzpool4
> -Replaces: libzpool2, libzpool2linux, libzpool3linux, libzpool4
> +Breaks: libzpool2, libzpool2linux, libzpool3linux, libzpool4, libzpool4linux
> +Replaces: libzpool2, libzpool2linux, libzpool3linux, libzpool4, libzpool4linux
this change should not be needed - the new package does not contain any
files that the old one did, and no conflict arises from both being
installed in parallel? for shared libraries with so-versioning you want
them to be coinstallable in general to allow for transitions/reduce
friction on upgrades, the old version can then be autoremoved
post-transition/upgrade if nothing depends on it anymore.
> Description: OpenZFS pool library for Linux
> OpenZFS is a storage platform that encompasses the functionality of
> traditional filesystems and volume managers. It supports data checksums,
> @@ -274,7 +274,7 @@ Suggests: libnvpair3linux-dbgsym,
> libuutil3linux-dbgsym,
> libzfs4linux-dbgsym,
> libzfsbootenv1linux-dbgsym,
> - libzpool4linux-dbgsym,
> + libzpool5linux-dbgsym,
> zfs-test-dbgsym,
> zfsutils-linux-dbgsym,
> zfs-zed-dbgsym,
> diff --git a/debian/libzpool4linux.docs b/debian/libzpool5linux.docs
> similarity index 100%
> rename from debian/libzpool4linux.docs
> rename to debian/libzpool5linux.docs
> diff --git a/debian/libzpool4linux.install.in b/debian/libzpool5linux.install.in
> similarity index 100%
> rename from debian/libzpool4linux.install.in
> rename to debian/libzpool5linux.install.in
> diff --git a/debian/libzpool4linux.lintian-overrides b/debian/libzpool5linux.lintian-overrides
> similarity index 100%
> rename from debian/libzpool4linux.lintian-overrides
> rename to debian/libzpool5linux.lintian-overrides
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2021-09-08 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:17 [pve-devel] [RFC zfsonlinux 0/5] update to 2.1.1 Stoiko Ivanov
2021-09-07 13:17 ` [pve-devel] [RFC zfsonlinux 1/5] update submodule and patches to ZFS 2.1.1-staging Stoiko Ivanov
2021-09-07 13:17 ` [pve-devel] [RFC zfsonlinux 2/5] buildsys: adapt install paths for zfs 2.1.0 Stoiko Ivanov
2021-09-07 13:17 ` [pve-devel] [RFC zfsonlinux 3/5] port changes to abi tracking from master Stoiko Ivanov
2021-09-07 13:17 ` [pve-devel] [RFC zfsonlinux 4/5] update abi definitions for 2.1.1 Stoiko Ivanov
2021-09-07 13:17 ` [pve-devel] [RFC zfsonlinux 5/5] bump libzpool soname Stoiko Ivanov
2021-09-08 11:51 ` Fabian Grünbichler [this message]
2021-09-08 11:53 ` [pve-devel] [RFC zfsonlinux 0/5] update to 2.1.1 Fabian Grünbichler
2021-09-08 12:25 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1631101569.c2kwj78so3.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox