From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 container] fix #4192: revamp check for systemd version
Date: Wed, 16 Nov 2022 13:14:24 +0100 [thread overview]
Message-ID: <16268683-f198-11c7-446a-b2bd541fd5ac@proxmox.com> (raw)
In-Reply-To: <9cd03fec-b052-1f71-97cd-45b4f68c7a62@proxmox.com>
Am 16/11/2022 um 13:13 schrieb Thomas Lamprecht:
> actually I did not yet pushed it out and rethought this, while I don't think that
> the perm change is problematic w.r.t. backward compat in practice, it seems a bit
> odd to argue for disk only, maybe we need to also check for CDROM, as cloudinit
> *adds* a cdrom drive, so it may required that too.
>
> But, to decide that I wanted to check our privilege docs, only to notice that
> we do not mention the cloudinit one there at all, not great...
>
> https://pve.proxmox.com/pve-docs/chapter-pveum.html#_privileges
>
> Please check the dev history to see if Cloudinit is deemed enough to add the CDROM
> or if we should add that priv to the check too, then re-send this with updated
> commit message, the whitespace fixes and a docs patch.
>
argh, replied to the wrong patch, please ignore.
prev parent reply other threads:[~2022-11-16 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 11:52 Leo Nunner
2022-11-08 17:23 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-16 12:13 ` [pve-devel] " Thomas Lamprecht
2022-11-16 12:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16268683-f198-11c7-446a-b2bd541fd5ac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox