From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared
Date: Thu, 08 Jul 2021 09:23:01 +0200 [thread overview]
Message-ID: <1625728893.2k8ou7fh82.astroid@nora.none> (raw)
In-Reply-To: <20210707102250.5478-1-f.ebner@proxmox.com>
On July 7, 2021 12:22 pm, Fabian Ebner wrote:
> Shared storages are not scanned for migration either, so they cannot
> be problematic in this context. This could lead to false positives
> where it actually is completely unproblematic:
>
> https://forum.proxmox.com/threads/proxmox-ve-7-0-released.92007/post-401165
but the behaviour changes for shared storages as well? previously,
vdisk_list would list regardless of content type settings, now it
properly filters, so volumes on shared storage "disappear"..
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/CLI/pve6to7.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
> index 69ed6d2e..17da70e8 100644
> --- a/PVE/CLI/pve6to7.pm
> +++ b/PVE/CLI/pve6to7.pm
> @@ -707,6 +707,7 @@ sub check_storage_content {
> for my $storeid (sort keys $storage_cfg->{ids}->%*) {
> my $scfg = $storage_cfg->{ids}->{$storeid};
>
> + next if $scfg->{shared};
> next if !PVE::Storage::storage_check_enabled($storage_cfg, $storeid, undef, 1);
>
> my $valid_content = PVE::Storage::Plugin::valid_content_types($scfg->{type});
> --
> 2.20.1
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2021-07-08 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 10:22 Fabian Ebner
2021-07-07 10:22 ` [pve-devel] [PATCH manager 2/2] pve6to7: storage content: ignore misconfigured unreferenced volumes Fabian Ebner
2021-07-08 7:29 ` Fabian Grünbichler
2021-07-08 7:37 ` Thomas Lamprecht
2021-07-08 7:23 ` Fabian Grünbichler [this message]
2021-07-08 7:26 ` [pve-devel] applied: [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625728893.2k8ou7fh82.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox