From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #3367: skip bind mounts when converting to template
Date: Tue, 22 Jun 2021 09:20:54 +0200 [thread overview]
Message-ID: <1624346326.6q3kwon9o5.astroid@nora.none> (raw)
In-Reply-To: <20210621084108.vjilobjck6kme4hb@olga.proxmox.com>
On June 21, 2021 10:41 am, Wolfgang Bumiller wrote:
> On Tue, Apr 06, 2021 at 08:26:50AM +0200, Fabian Ebner wrote:
>> It turns out that we do not yet allow cloning from container templates with
>> bind mounts. So in a sense container templates with bind mounts are
>> currently misconfigured, and this patch would make it easier to get there...
>>
>> Should I send a v2 with a patch making cloning from such templates possible,
>> or were there some concerns to not allow it in the first place? There is a
>> # TODO: allow bind mounts?
>> comment in the clone API call.
>
> It's mostly that bind mounts are generally root-only.
maybe we should re-visit the idea of "admin-defined bind mounts" (or
rather, "admin-defined bind mount SOURCES") that have ACLs, so that we
can make them more accessible to regular users..
> Silently dropping them when converting to a template seems awkward, I'd
> rather have this throw an error, too.
>
> (Also remember that containers don't need to be templates to be cloned.)
prev parent reply other threads:[~2021-06-22 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 12:36 Fabian Ebner
2021-04-06 6:26 ` Fabian Ebner
2021-06-21 8:41 ` Wolfgang Bumiller
2021-06-22 7:20 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624346326.6q3kwon9o5.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox