From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server] fix #3369: auto-start vm after failed stopmode backup
Date: Thu, 22 Apr 2021 10:42:15 +0200 [thread overview]
Message-ID: <1619080870.b4j72slfn6.astroid@nora.none> (raw)
In-Reply-To: <20210420131437.25039-1-d.whyte@proxmox.com>
On April 20, 2021 3:14 pm, Dylan Whyte wrote:
> Fixes an issue in which a VM/CT fails to automatically restart after a
> failed stop-mode backup.
>
> Also fixes a minor typo in a comment
>
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Note:
>
> v1->v2:
> - Fix the issue from within PVE::VZDump::QemuServer, rather than adding
> tedious sleep call and state checking in PVE::VZDump.
>
> PVE/VZDump/QemuServer.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
> index 8920ac1f..42a60fc7 100644
> --- a/PVE/VZDump/QemuServer.pm
> +++ b/PVE/VZDump/QemuServer.pm
> @@ -551,6 +551,7 @@ sub archive_pbs {
> if ($err) {
> $self->logerr($err);
> $self->mon_backup_cancel($vmid);
> + $self->resume_vm_after_job_start($task, $vmid);
> }
> $self->restore_vm_power_state($vmid);
>
> @@ -729,6 +730,7 @@ sub archive_vma {
> if ($err) {
> $self->logerr($err);
> $self->mon_backup_cancel($vmid);
> + $self->resume_vm_after_job_start($task, $vmid);
> }
>
> $self->restore_vm_power_state($vmid);
> @@ -815,7 +817,7 @@ sub enforce_vm_running_for_backup {
> die $@ if $@;
> }
>
> -# resume VM againe once we got in a clear state (stop mode backup of running VM)
> +# resume VM again once in a clear state (stop mode backup of running VM)
> sub resume_vm_after_job_start {
> my ($self, $task, $vmid) = @_;
>
> --
> 2.20.1
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2021-04-22 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 13:14 Dylan Whyte
2021-04-22 8:42 ` Fabian Grünbichler [this message]
2021-04-22 9:36 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619080870.b4j72slfn6.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox