Re: [pve-devel] [PATCH storage v4 1/4] pbs: Move pbs_api_connect earlyer in the code

[Fiona Ebner <f.ebner@proxmox.com>]

Am 27.11.23 um 12:39 schrieb Philipp Hufnagl:
> Because it is needed later in this patch series, the method
> pbs_api_connect is moved earlyer in the code

Typo: /earlyer/earlier/ (also in the title)

> 
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
>  src/PVE/Storage/PBSPlugin.pm | 63 ++++++++++++++++++------------------
>  1 file changed, 32 insertions(+), 31 deletions(-)
> 
> diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm
> index 4320974..96373a4 100644
> --- a/src/PVE/Storage/PBSPlugin.pm
> +++ b/src/PVE/Storage/PBSPlugin.pm
> @@ -112,6 +112,38 @@ sub pbs_get_password {
>      return PVE::Tools::file_read_firstline($pwfile);
>  }
>  

I don't think this is the best place to move it to, because it's now
beteween the helpers for password and the helpers for the encryption
key. I'd like to have it either before or after those password and key
related helpers.

> +#

Nit: adds an extra #

> +# TODO: use a client with native rust/proxmox-backup bindings to profit from
> +# API schema checks and types