public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	pve-devel@pve.proxmox.com
Subject: Re: [pve-devel] [docs: ] [PATCH pve-docs] add properties to execute in api-viewer
Date: Fri, 30 Oct 2020 15:32:15 +0100	[thread overview]
Message-ID: <1604068269.61q6m7sdm5.astroid@nora.none> (raw)
In-Reply-To: <20201030141700.237854-1-m.almalat@proxmox.com>

On October 30, 2020 3:17 pm, Moayad Almalat wrote:
> Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
> 
> * when clicked on "execute" in api-view the page not handling.
> * In browser console printed this error:
> 'TypeError: Cannot read property 'properties' of undefined'
> * https://forum.proxmox.com/threads/api-browse-execute-returns-error.78257/
> ---
>  api-viewer/apidata.js | 7 +++++--

this is a generated file.. so either the dumper that generates it or the 
code that accesses it without checking for undefined needs to be fixed, 
not the generated file ;)

>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/api-viewer/apidata.js b/api-viewer/apidata.js
> index a438090..048509f 100644
> --- a/api-viewer/apidata.js
> +++ b/api-viewer/apidata.js
> @@ -37324,8 +37324,11 @@ var pveapi = [
>                          "protected" : 1,
>                          "proxyto" : "node",
>                          "returns" : {
> -                           "type" : "array"
> -                        }
> +                           "items" : {
> +                              "properties" : {},
> +                              "type" : "array"
> +                           }
> +                        },
>                       }
>                    },
>                    "leaf" : 1,
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 




      reply	other threads:[~2020-10-30 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 14:17 Moayad Almalat
2020-10-30 14:32 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604068269.61q6m7sdm5.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=pve-devel@pve.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal