From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] partially fix #3056: namespace vzdump tmpdir with vmid
Date: Tue, 20 Oct 2020 09:13:32 +0200 [thread overview]
Message-ID: <1603177890.kgrk7q62n7.astroid@nora.none> (raw)
In-Reply-To: <20201019141525.5480-1-d.csapak@proxmox.com>
On October 19, 2020 4:15 pm, Dominik Csapak wrote:
> this fixes an issue where a rogue running backup would upload the vm
> config of a later backup in a backup job
>
> instead now that directory gets deleted and the config is not
> available anymore
>
> we cannot really keep those directories around until the end of the
> backup job, since we temporarily save ct contents there, which could get
> large very fast
Wolfang made the suggestion yesterday that we could get Qemu to open it
directly after being passed the path via QMP, that way vzdump can delete
it but Qemu still has a reference to the old (correct) file. might be a
good additional followup even with this change?
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/VZDump.pm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 542228d6..cdcb658f 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -769,10 +769,11 @@ sub exec_backup_task {
>
> $task->{vmtype} = $vmtype;
>
> + my $pid = $$;
> if ($opts->{tmpdir}) {
> - $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp$$";
> + $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp${pid}_$vmid/";
> } elsif ($self->{opts}->{pbs}) {
> - $task->{tmpdir} = "/var/tmp/vzdumptmp$$"; #fixme
> + $task->{tmpdir} = "/var/tmp/vzdumptmp${pid}_$vmid";
> } else {
> # dumpdir is posix? then use it as temporary dir
> my $info = get_mount_info($opts->{dumpdir});
> @@ -780,7 +781,7 @@ sub exec_backup_task {
> grep ($_ eq $info->{fstype}, @posix_filesystems)) {
> $task->{tmpdir} = "$opts->{dumpdir}/$basename.tmp";
> } else {
> - $task->{tmpdir} = "/var/tmp/vzdumptmp$$";
> + $task->{tmpdir} = "/var/tmp/vzdumptmp${pid}_$vmid";
> debugmsg ('info', "filesystem type on dumpdir is '$info->{fstype}' -" .
> "using $task->{tmpdir} for temporary files", $logfd);
> }
> --
> 2.20.1
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2020-10-20 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 14:15 Dominik Csapak
2020-10-20 7:13 ` Fabian Grünbichler [this message]
2020-10-22 16:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603177890.kgrk7q62n7.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox