From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v11 manager 0/3] fix#1710: add download from url button
Date: Fri, 2 Jul 2021 08:59:59 +0200 [thread overview]
Message-ID: <15e3d105-c38d-b015-c23f-2a2ac4249c73@proxmox.com> (raw)
In-Reply-To: <20210701085007.2811779-1-l.stechauner@proxmox.com>
works, patches look good
Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
On 7/1/21 10:50, Lorenz Stechauner wrote:
> changes to v10:
> * dropped already applied patches
> * added "check" button - the gui now does not automatically send the metadata request anymore
> * removed (visible) content type selector, because there was only one hard-coded option every time
> * added loading mask while the metadata check is in progress
>
> Lorenz Stechauner (3):
> api: nodes: add query_url_metadata method
> ui: Utils: change download task format
> fix #1710: ui: storage: add download from url button
>
> PVE/API2/Nodes.pm | 96 ++++++++++
> www/manager6/Utils.js | 2 +-
> www/manager6/storage/Browser.js | 8 +
> www/manager6/storage/ContentView.js | 262 +++++++++++++++++++++++++---
> 4 files changed, 343 insertions(+), 25 deletions(-)
>
next prev parent reply other threads:[~2021-07-02 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 8:50 Lorenz Stechauner
2021-07-01 8:50 ` [pve-devel] [PATCH v11 manager 1/3] api: nodes: add query_url_metadata method Lorenz Stechauner
2021-07-01 8:50 ` [pve-devel] [PATCH v11 manager 2/3] ui: Utils: change download task format Lorenz Stechauner
2021-07-01 8:50 ` [pve-devel] [PATCH v11 manager 3/3] fix #1710: ui: storage: add download from url button Lorenz Stechauner
2021-07-02 6:59 ` Dominik Csapak [this message]
2021-07-05 6:51 ` [pve-devel] applied: [PATCH v11 manager 0/3] fix#1710: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e3d105-c38d-b015-c23f-2a2ac4249c73@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox