public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH common/widget-toolkit v4] implement oneOf schema
Date: Fri, 17 Nov 2023 10:06:50 +0100	[thread overview]
Message-ID: <15cb75b8-01db-4998-bf52-992fed131e44@proxmox.com> (raw)
In-Reply-To: <20231116152152.1371406-1-d.csapak@proxmox.com>

Am 16/11/2023 um 16:21 schrieb Dominik Csapak:
> this series implementes the oneOf schema for the api, see the individual
> patches for more details and changelog
> 
> only change is the fixed test for pve-common 3/3
> (did accidentally include the wrong file when sending the patches)
> 
> pve-common:
> 
> Dominik Csapak (5):
>   section config: add test for the schemas
>   tools: add is_deeply
>   json schema: implement 'oneOf' schema
>   section config: allow separated property lists for plugins
>   section config: add tests for separated property lists
> 
>  src/PVE/CLIHandler.pm                 |   2 +-
>  src/PVE/JSONSchema.pm                 | 116 +++++-
>  src/PVE/RESTHandler.pm                |  82 ++++-
>  src/PVE/SectionConfig.pm              | 312 +++++++++++++---
>  src/PVE/Tools.pm                      |  31 ++
>  test/Makefile                         |   2 +
>  test/is_deeply_test.pl                | 142 ++++++++
>  test/section_config_separated_test.pl | 489 ++++++++++++++++++++++++++
>  test/section_config_test.pl           | 133 +++++++
>  9 files changed, 1239 insertions(+), 70 deletions(-)
>  create mode 100755 test/is_deeply_test.pl
>  create mode 100755 test/section_config_separated_test.pl
> 
> proxmox-widget-toolkit:
> 
> Dominik Csapak (1):
>   api-viewer: implement basic oneOf support
> 
>  src/api-viewer/APIViewer.js | 34 +++++++++++++++++++++++++++++++---
>  1 file changed, 31 insertions(+), 3 deletions(-)
> 


applied series, thanks!

As talked off-list, I did a few small squashes to ensure that the isolation (vs.
separated) terminology is used consistently, and changed the interface from passing
an, a bit opaque, "boolean" to enable the property isolation, to a more telling
property_isolation => 1 hash entry.




      parent reply	other threads:[~2023-11-17  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 15:21 [pve-devel] " Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH common v4 1/5] section config: add test for the schemas Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH common v4 2/5] tools: add is_deeply Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH common v4 3/5] json schema: implement 'oneOf' schema Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH common v4 4/5] section config: allow separated property lists for plugins Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH common v4 5/5] section config: add tests for separated property lists Dominik Csapak
2023-11-16 15:21 ` [pve-devel] [PATCH widget-toolkit v4 1/1] api-viewer: implement basic oneOf support Dominik Csapak
2023-11-17  9:06 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15cb75b8-01db-4998-bf52-992fed131e44@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal