[pve-devel] [PATCH manager] vzdump: allow backups on btrfs

[pve-devel] [PATCH manager] vzdump: allow backups on btrfs

[Oguz Bektas]

see forum post [0]

[0]:
https://forum.proxmox.com/threads/cant-use-storage-type-btrfs-for-backup-500-help.92918/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 PVE/VZDump.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 46cb9e6d..39b5e46d 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -102,7 +102,8 @@ sub storage_info {
 
     die "can't use storage type '$type' for backup\n"
 	if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'
-	      || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'));
+	      || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'
+	      || $type eq 'btrfs'));
     die "can't use storage '$storage' for backups - wrong content type\n"
 	if (!$scfg->{content}->{backup});
 
-- 
2.30.2

Re: [pve-devel] [PATCH manager] vzdump: allow backups on btrfs

[Thomas Lamprecht]

On 19.07.21 13:58, Oguz Bektas wrote:
> see forum post [0]
> 
> [0]:
> https://forum.proxmox.com/threads/cant-use-storage-type-btrfs-for-backup-500-help.92918/
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  PVE/VZDump.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 46cb9e6d..39b5e46d 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -102,7 +102,8 @@ sub storage_info {
>  
>      die "can't use storage type '$type' for backup\n"
>  	if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'
> -	      || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'));
> +	      || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'
> +	      || $type eq 'btrfs'));

Rather, that whole check above needs to be removed, we can derive that from
$scfg->{content}->{backup} below already, that can only get set when on a
storage that declares to support backups, and actually works for external
ttorage plugins too.

>      die "can't use storage '$storage' for backups - wrong content type\n"
>  	if (!$scfg->{content}->{backup});
>  
>