public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Tim Marx <t.marx@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 access-control] add ui capabilities endpoint
Date: Thu, 10 Sep 2020 10:23:23 +0200	[thread overview]
Message-ID: <1599726085.e9262tw99c.astroid@nora.none> (raw)
In-Reply-To: <008ff748-78d4-ec63-9680-e6129cf7993d@proxmox.com>

On September 10, 2020 10:19 am, Thomas Lamprecht wrote:
> On 10.09.20 10:00, Fabian Grünbichler wrote:
>> also, permissions has a return schema already, while it does 'match' 
>> from a structural point of view (a two-level deep hash), it is something 
>> altogether different semantically.
> 
> as the semantics are actively controlled by the requested via a switch that
> does not matters much, IMO. They then actively request another semantic.

sure. it's just not very clean ;)

>> TL;DR: iff we really need this, then I'd put it in a separate API call.
> We could also just do the "cap heuristic calculation" in the frontend, using
> the full permissions, and fill the Cap object with it.
> This avoids a new api call or new multiplexer switch for an existing one but
> does not needs to restructure the whole UI cap control, yet.

I think I'd prefer this, should be straight-forward to port from Perl to 
JS.




  reply	other threads:[~2020-09-10  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200706124544.2126341-1-t.marx@proxmox.com>
2020-09-09 19:00 ` Thomas Lamprecht
2020-09-10  8:00   ` Fabian Grünbichler
2020-09-10  8:19     ` Thomas Lamprecht
2020-09-10  8:23       ` Fabian Grünbichler [this message]
2020-09-10  8:28         ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599726085.e9262tw99c.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@pve.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    --cc=t.marx@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal