From: Christian Ebner <c.ebner@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow
Date: Wed, 10 Jan 2024 14:43:16 +0100 (CET) [thread overview]
Message-ID: <1593135089.2170.1704894196191@webmail.proxmox.com> (raw)
In-Reply-To: <9a3474b0-3422-4bda-b669-f28067351008@proxmox.com>
> On 10.01.2024 14:37 CET Lukas Wagner <l.wagner@proxmox.com> wrote:
>
>
> On 1/10/24 14:14, Christian Ebner wrote:
> > Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> > ---
> > notifications.adoc | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/notifications.adoc b/notifications.adoc
> > index cddb8ca..9be23f8 100644
> > --- a/notifications.adoc
> > +++ b/notifications.adoc
> > @@ -172,11 +172,11 @@ Notification Matchers
> > [thumbnail="screenshot/gui-datacenter-notification-matcher.png"]
> >
> > Notification matchers route notifications to notification targets based
> > -on their matching rules. These rules can match of certain properties of
> > -a notification, such as the timestamp (`match-calendar`), the severity of
> > -the notificaiton (`match-severity`) or metadata fiels (`match-field`).
> > -If a matcher matches a notification, all targets configured for the matcher
> > -will receive the notification.
> > +on their matching rules. These rules can match certain properties of a
> > +notification, such as the timestamp (`match-calendar`), the severity of
> > +the notificaiton (`match-severity`) or metadata fields (`match-field`).
> ^
> Spotted another typo here
Ah, yes, will send a v2. Thanks for noticing!
>
> > +If a notification is matched by a matcher, all targets configured for the
> > +matcher will receive the notification.
> >
> > An arbitrary number of matchers can be created, each with with their own
> > matching rules and targets to notify.
>
> I guess I wrote that paragraph in a bit of a hurry :)
>
> Thanks!
No worries!
prev parent reply other threads:[~2024-01-10 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 13:14 Christian Ebner
2024-01-10 13:37 ` Lukas Wagner
2024-01-10 13:43 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593135089.2170.1704894196191@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox