From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pve-devel] vncpropxy question
Date: Thu, 30 Jun 2022 13:50:45 +0200 [thread overview]
Message-ID: <14c7b0c7-f379-6a97-6e4a-21e103690b40@proxmox.com> (raw)
In-Reply-To: <725dbe83-2a4c-7eab-a053-3f87f2be5f51@proxmox.com>
On 6/30/22 13:25, Dominik Csapak wrote:
> On 6/30/22 13:02, Dietmar Maurer wrote:
>> in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to
>> me, because it make all other connection failing...
>>
>>
>> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
>> index 99b426e..c6a3ac1 100644
>> --- a/PVE/API2/Qemu.pm
>> +++ b/PVE/API2/Qemu.pm
>> @@ -2102,7 +2102,7 @@ __PACKAGE__->register_method({
>> } else {
>> - $ENV{LC_PVE_TICKET} = $password if $websocket; # set ticket with "qm vncproxy"
>> + $ENV{LC_PVE_TICKET} = $password;
>> $cmd = [@$remcmd, "/usr/sbin/qm", 'vncproxy', $vmid];
>>
>>
>
> AFAICS, this is a remnant of old code where we would start wsproxy.py instead of our
> 'qm vncproxy'
>
> i think we could remove the whole websocket parameter as it doesn't
> do anything here
>
> so we could do
> 1. remove the use of $websocket here
> 2. remove the websocket=1 parameter in novnc
> 3. remove the websocket parameter completely (in 8.0, since it's a breaking api change)
>
addendum:
'it doesn't do anything here' is not completely correct
for 'regular' vm displays it just does not set the ticket which
breaks the connection
for use with a serial terminal in the vm, we also
set '-notls' and '-listen localhost' for vncterm
if we'd drop the parameter anyway (with 8.0) and use always
'-notls -listen localhost' i think we could drop the custom
libvncserver package in vncterm and use the debian packaged
one (since we'd never use tls then anyway)
we could even go a step further and remove support for terminals
over vnc completely, since we have support for that in the
browser with xterm.js since quite some time
next prev parent reply other threads:[~2022-06-30 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:02 Dietmar Maurer
2022-06-30 11:25 ` Dominik Csapak
2022-06-30 11:50 ` Dominik Csapak [this message]
2022-06-30 11:55 ` Thomas Lamprecht
2022-07-01 6:39 Dietmar Maurer
2022-07-01 12:01 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14c7b0c7-f379-6a97-6e4a-21e103690b40@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox