public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 2/2] partially fix #5139: document qnetd port requirement
Date: Mon, 19 Feb 2024 16:34:14 +0100	[thread overview]
Message-ID: <1476b8cf-429c-46a9-8009-7b3c69d35cea@proxmox.com> (raw)
In-Reply-To: <20231221092922.115949-2-f.gruenbichler@proxmox.com>

Am 21.12.23 um 10:29 schrieb Fabian Grünbichler:
> we could also add a check somewhere in pve-cluster for this.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  pvecm.adoc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/pvecm.adoc b/pvecm.adoc
> index 03fba9f..adfc33f 100644
> --- a/pvecm.adoc
> +++ b/pvecm.adoc
> @@ -1100,6 +1100,9 @@ columns:
>     https://manpages.debian.org/bookworm/libvotequorum-dev/votequorum_qdevice_master_wins.3.en.html].
>  * `NR`: QDevice is not registered.
>  
> +NOTE: If your Qdevice is listed as `Not Alive` (`NA` in the output above),

I'd change this to "QDevice", which is what all the other text uses
(just not the output for the pvecm command).

> +ensure that port "5403" of your external server is reachable via TCP/IP!

I'd prefer to drop the quotes or even use `5403`. We could also mention
"(default port of the qnetd server)".

Let me know what you think. I can squash in the changes we agree upon
when applying.




  reply	other threads:[~2024-02-19 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21  9:29 [pve-devel] [PATCH docs 1/2] fix #5140: qdevice SSH access documentation Fabian Grünbichler
2023-12-21  9:29 ` [pve-devel] [PATCH docs 2/2] partially fix #5139: document qnetd port requirement Fabian Grünbichler
2024-02-19 15:34   ` Fiona Ebner [this message]
2024-02-20 15:02   ` [pve-devel] applied: " Thomas Lamprecht
2024-02-20 15:01 ` [pve-devel] applied: [PATCH docs 1/2] fix #5140: qdevice SSH access documentation Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476b8cf-429c-46a9-8009-7b3c69d35cea@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal