From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 1/3] ship proper nodejs module 'pve-eslint'
Date: Mon, 30 Aug 2021 11:17:46 +0200 [thread overview]
Message-ID: <1438230b-4262-755f-0d3a-2c08f941388f@proxmox.com> (raw)
In-Reply-To: <5fdfd5ae-d601-3032-37f8-8b5ec618dc9e@proxmox.com>
On 8/25/21 18:38, Thomas Lamprecht wrote:
> On 19/07/2021 12:31, Dominik Csapak wrote:
>> instead of concatenating the eslint module into our app.js, ship
>> a 'pve-eslint' module that exports the built eslint module
>>
>> to do this, we have to leave the module type on 'umd' instead of
>> changing to 'var' so that nodejs can properly import it.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> Makefile | 2 +-
>
> Does not applies here, did not really investigated yet though:
>
> Applying: ship proper nodejs module 'pve-eslint'
> Using index info to reconstruct a base tree...
> error: removal patch leaves file contents
> error: src/Makefile: patch does not apply
>
>
ah yes, sorry, i created the patches with '-D'
since the second patch would not fit on the mailing list
shall i send 1/3 and 3/3 again with out -D ?
the only conflict is that src/Makefile is deleted
(2/3 can be done separately anyway)
next prev parent reply other threads:[~2021-08-30 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 10:31 [pve-devel] [PATCH v2 0/3] make linting threaded Dominik Csapak
2021-07-19 10:31 ` [pve-devel] [PATCH v2 1/3] ship proper nodejs module 'pve-eslint' Dominik Csapak
2021-08-25 16:38 ` Thomas Lamprecht
2021-08-30 9:17 ` Dominik Csapak [this message]
2021-08-30 9:25 ` Thomas Lamprecht
2021-08-30 10:06 ` Dominik Csapak
2021-08-30 10:36 ` [pve-devel] applied: " Thomas Lamprecht
2021-08-30 10:43 ` Dominik Csapak
2021-08-30 11:03 ` Thomas Lamprecht
2021-07-19 10:31 ` [pve-devel] [PATCH v2 2/3] remove unnecessary eslint.js Dominik Csapak
2021-07-19 10:31 ` [pve-devel] [PATCH v2 3/3] use worker_threads for linting Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438230b-4262-755f-0d3a-2c08f941388f@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox