From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v3] api: ceph: improve reporting of ceph OSD memory usage
Date: Mon, 4 Sep 2023 15:14:28 +0200 [thread overview]
Message-ID: <14129d30-0d14-4700-aa49-0afd2607f236@proxmox.com> (raw)
In-Reply-To: <20230904091807.687469-1-s.hanreich@proxmox.com>
Am 04/09/2023 um 11:18 schrieb Stefan Hanreich:
> ---
> Changes from v2:
> * closing the file handle after using it
> * improved error message when failing to open proc file
> * add hint in the UI that we are using PSS
> * mentioned Aaron's involvement in commit message
missing factoring this out to own helper to avoid crowding the API endpoint
code itself to much, like asked in my review.. If you don't agree please
state that at least, ideally with a reason..
>
> Changes from v1:
> * now returns 0 instead of null in case of stopped OSDs in order to
> preserve backwards compatibility
>
> PVE/API2/Ceph/OSD.pm | 21 ++++++++++++++++-----
> www/manager6/ceph/OSDDetails.js | 2 +-
> 2 files changed, 17 insertions(+), 6 deletions(-)
>
>
applied, with two follow ups, a clean-up one for previous existing code
and factoring this out and adapting error handling as second, thanks!
next prev parent reply other threads:[~2023-09-04 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:18 [pve-devel] " Stefan Hanreich
2023-09-04 13:14 ` Thomas Lamprecht [this message]
2023-09-04 13:47 ` [pve-devel] applied: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14129d30-0d14-4700-aa49-0afd2607f236@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox