* [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot
@ 2021-07-12 8:32 Stoiko Ivanov
2021-07-12 10:02 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2021-07-12 8:32 UTC (permalink / raw)
To: pve-devel
This is (afaics) a purely cosmetic change.
With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer
environment anymore - ifup/ifdown are currently provided by busybox.
Since we stop all daemonized processes with killall5, this takes care
of the dhclient instances - so just drop the invocation of the non
existing script.
Noticed while checking out 2 improvments to the installer.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
unconfigured.sh | 2 --
1 file changed, 2 deletions(-)
diff --git a/unconfigured.sh b/unconfigured.sh
index 98b8d9c..35ec0ee 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -47,8 +47,6 @@ eject_and_reboot() {
real_reboot() {
trap - ERR
- /etc/init.d/networking stop
-
# stop udev (release file handles)
/etc/init.d/udev stop
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot
2021-07-12 8:32 [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot Stoiko Ivanov
@ 2021-07-12 10:02 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-12 10:02 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 12.07.21 10:32, Stoiko Ivanov wrote:
> This is (afaics) a purely cosmetic change.
>
> With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer
> environment anymore - ifup/ifdown are currently provided by busybox.
>
> Since we stop all daemonized processes with killall5, this takes care
> of the dhclient instances - so just drop the invocation of the non
> existing script.
>
> Noticed while checking out 2 improvments to the installer.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> unconfigured.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/unconfigured.sh b/unconfigured.sh
> index 98b8d9c..35ec0ee 100755
> --- a/unconfigured.sh
> +++ b/unconfigured.sh
> @@ -47,8 +47,6 @@ eject_and_reboot() {
> real_reboot() {
> trap - ERR
>
> - /etc/init.d/networking stop
> -
> # stop udev (release file handles)
> /etc/init.d/udev stop
>
>
funnily noticed that too and had a `if [[ -x /etc/init.d/networking ]]; ...` already committed
locally, I pushed that one out - may make sense to fully remove it in the future.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-12 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 8:32 [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot Stoiko Ivanov
2021-07-12 10:02 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox