public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH manager 1/2] ui: remove handling of obsolete notification-policy/target settings
Date: Tue, 24 Jun 2025 13:30:19 +0200	[thread overview]
Message-ID: <13ae3cda-112f-49b0-9f73-fd8e2379f86c@proxmox.com> (raw)
In-Reply-To: <20250612095548.137819-1-l.wagner@proxmox.com>

Superseded-by:
https://lore.proxmox.com/all/20250624112817.132312-1-l.wagner@proxmox.com/T/#t

On  2025-06-12 11:55, Lukas Wagner wrote:
> These were only used in the 'old' revamped notification stack which was
> briefly available on pvetest. With PVE 9 we can finally get completely
> rid of these.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Only intended for PVE 9.
> 
>  www/manager6/dc/Backup.js | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 381402ca..688befe7 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -37,14 +37,6 @@ Ext.define('PVE.dc.BackupEdit', {
>  		delete values.node;
>  	    }
>  
> -	    // Get rid of new-old parameters for notification settings.
> -	    // These should only be set for those selected few who ran
> -	    // pve-manager from pvetest.
> -	    if (!isCreate) {
> -		Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-policy' });
> -		Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-target' });
> -	    }
> -
>  	    let selMode = values.selMode;
>  	    delete values.selMode;
>  
> @@ -158,14 +150,6 @@ Ext.define('PVE.dc.BackupEdit', {
>  	    let me = this;
>  	    let viewModel = me.getViewModel();
>  
> -	    // Migrate 'new'-old notification-policy back to old-old mailnotification.
> -	    // Only should affect users who used pve-manager from pvetest. This was a remnant of
> -	    // notifications before the  overhaul.
> -	    let policy = data['notification-policy'];
> -	    if (policy === 'always' || policy === 'failure') {
> -		data.mailnotification = policy;
> -	    }
> -
>  	    if (data.exclude) {
>  		data.vmid = data.exclude;
>  		data.selMode = 'exclude';

-- 
- Lukas



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-06-24 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  9:55 [pve-devel] " Lukas Wagner
2025-06-12  9:55 ` [pve-devel] [PATCH manager 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-06-24 11:30 ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ae3cda-112f-49b0-9f73-fd8e2379f86c@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal