From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Date: Wed, 12 Feb 2025 11:57:24 +0100 (CET) [thread overview]
Message-ID: <1388881127.6288.1739357844911@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.127.1738931654.293.pve-devel@lists.proxmox.com>
> Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com> hat am 07.02.2025 13:34 CET geschrieben:
> On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote:
> >
> > > Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com> hat am 07.02.2025 10:02 CET geschrieben:
> > > Hi all,
> > >
> > > rather simple question I guess, but I could not find the answer in
> > > https://pve.proxmox.com/wiki/Storage_Plugin_Development and linked
> > > documents and looks like my grep foo is lacking today, so here we go:
> > > I guess I know what the first hash in the 'content' array is, but what
> > > is the second? Actually, why is there a second one?
> > >
> > > Storage/LVMPlugin.pm:
> > > content => [ {images => 1, rootdir => 1}, { images => 1 }]
> > >
> > > vs.
> > >
> > > Storage/LvmThinPlugin.pm:
> > > content => [ {images => 1, rootdir => 1}, { images => 1, rootdir => 1}]
> > >
> > > Best, rck
> >
> > the first one defines the allowed/valid content types, the second the default one(s):
>
> thanks Fabian and Fiona, that explains it.
>
> > we are working on improving the docs and cleaning all of this up!
>
> that is great news, even after maintaining a plugin for some time it
> usually takes a deep dive into some core code to actually understand
> some of the API. If there is then something to review or give feedback
> from an external plugin dev's point of view feel free to explicitly ping
> me.
thank you for that offer, it is appreciated!
Fabian
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-12 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 9:02 Roland Kammerer via pve-devel
2025-02-07 9:18 ` Fabian Grünbichler
2025-02-07 12:34 ` Roland Kammerer via pve-devel
2025-02-12 10:57 ` Fabian Grünbichler [this message]
[not found] ` <Z6X9vOv2lCsvTy3o@arm64>
2025-02-25 10:50 ` Max Carrara
2025-03-07 8:24 ` Roland Kammerer via pve-devel
[not found] ` <Z8qtOTycFZpN5bpL@arm64>
2025-03-07 12:01 ` Roland Kammerer via pve-devel
2025-03-12 11:09 ` Max Carrara
2025-02-07 9:19 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388881127.6288.1739357844911@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal