From: Daniel Berteaud <daniel@firewall-services.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 0/2] LIO: fix tainted config and minor cleanup
Date: Mon, 12 Oct 2020 18:37:09 +0200 (CEST) [thread overview]
Message-ID: <1366393006.227944.1602520629190.JavaMail.zimbra@fws.fr> (raw)
In-Reply-To: <20201012153458.18685-1-s.ivanov@proxmox.com>
----- Le 12 Oct 20, à 17:34, Stoiko Ivanov s.ivanov@proxmox.com a écrit :
> This patchset follows the fix in 609f117ff24d2cff6b155e1d4b1175ceebe5bd7b.
> Since several operations rely on values read from the remote target's
> LIO config (which is tainted), this patchset untaints the settings, which are
> actually needed (and stores only those), while reading the config.
>
> The second patch removes two small left-over statements, which confused me
> while debugging.
>
> Tested very roughly (adding disks, create/rollback snapshot, remove disk) on
> a VM backed by a LIO-iSCSI target.
>
Just tested it on my install, and everything seems to be working again (tested disk creation, removal, resize, move, snapshot, rollback, delete snapshot)
Thanks !
--
[ https://www.firewall-services.com/ ]
Daniel Berteaud
FIREWALL-SERVICES SAS, La sécurité des réseaux
Société de Services en Logiciels Libres
Tél : +33.5 56 64 15 32
Matrix: @dani:fws.fr
[ https://www.firewall-services.com/ | https://www.firewall-services.com ]
next prev parent reply other threads:[~2020-10-12 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 15:34 Stoiko Ivanov
2020-10-12 15:34 ` [pve-devel] [PATCH storage 1/2] LIO: untaint values read from remote config Stoiko Ivanov
2020-10-12 15:34 ` [pve-devel] [PATCH storage 2/2] LIO: drop unused statements Stoiko Ivanov
2020-10-12 16:37 ` Daniel Berteaud [this message]
2020-10-13 9:15 ` [pve-devel] applied-series: [PATCH storage 0/2] LIO: fix tainted config and minor cleanup Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366393006.227944.1602520629190.JavaMail.zimbra@fws.fr \
--to=daniel@firewall-services.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox