[pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Dominik Csapak]

this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.

to fix this, make it 20px shorter

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively we could also increase the height in the create wizard

the optimal solution would be to improve the layouting in our
wizard/inputpanel altogether so that it automatically gets the right
height, but that is a non-trivial rework there. imho this should work
fine as a stopgap fix for now

(feel free to put above comment into the commit message if it seems
appropriate)

 www/manager6/form/VMCPUFlagSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index ace3c531..03a119ab 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -12,7 +12,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
     hideHeaders: true,
 
     scrollable: 'y',
-    height: 200,
+    height: 180,
 
     unkownFlags: [],
 
-- 
2.30.2

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Dominik Csapak]

forgot to write: we should apply this for stable-7 as well

On 6/15/23 10:08, Dominik Csapak wrote:
> this field has a fixed height, which is too tall for the create wizard,
> and one cannot see the last entry when scrolling all the way down.
> 
> to fix this, make it 20px shorter
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively we could also increase the height in the create wizard
> 
> the optimal solution would be to improve the layouting in our
> wizard/inputpanel altogether so that it automatically gets the right
> height, but that is a non-trivial rework there. imho this should work
> fine as a stopgap fix for now
> 
> (feel free to put above comment into the commit message if it seems
> appropriate)
> 
>   www/manager6/form/VMCPUFlagSelector.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ace3c531..03a119ab 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -12,7 +12,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>       hideHeaders: true,
>   
>       scrollable: 'y',
> -    height: 200,
> +    height: 180,
>   
>       unkownFlags: [],
>   

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Thomas Lamprecht]

Am 15/06/2023 um 10:08 schrieb Dominik Csapak:
> this field has a fixed height, which is too tall for the create wizard,
> and one cannot see the last entry when scrolling all the way down.
> 
> to fix this, make it 20px shorter

was still broken in the german translation, as that takes up more space in
a label higher up in the panel.

> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively we could also increase the height in the create wizard

I went for that route for now, increasing that from 510 to 540 (4:3 ratio
to width).

> the optimal solution would be to improve the layouting in our
> wizard/inputpanel altogether so that it automatically gets the right
> height, but that is a non-trivial rework there. imho this should work
> fine as a stopgap fix for now

just out of interest, could setting a flex+maxHeight for the extra-flags
also have been an option?

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Dominik Csapak]

On 11/6/23 17:31, Thomas Lamprecht wrote:
> Am 15/06/2023 um 10:08 schrieb Dominik Csapak:
>> this field has a fixed height, which is too tall for the create wizard,
>> and one cannot see the last entry when scrolling all the way down.
>>
>> to fix this, make it 20px shorter
> 
> was still broken in the german translation, as that takes up more space in
> a label higher up in the panel.
> 
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> alternatively we could also increase the height in the create wizard
> 
> I went for that route for now, increasing that from 510 to 540 (4:3 ratio
> to width).
> 

ok

>> the optimal solution would be to improve the layouting in our
>> wizard/inputpanel altogether so that it automatically gets the right
>> height, but that is a non-trivial rework there. imho this should work
>> fine as a stopgap fix for now
> 
> just out of interest, could setting a flex+maxHeight for the extra-flags
> also have been an option?

AFAICS there is no way to do that. The columns in an inputpanel
are an 'anchor' layout, and I could not set it so that it would
take the remaining height of the panel. But theoretically yes,
if we could make it 'flex' height + a maxHeight for the non wizard case
this would also work. (possibly with my mentioned rework of the input panel layout)

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Thomas Lamprecht]

Am 07/11/2023 um 08:50 schrieb Dominik Csapak:
> On 11/6/23 17:31, Thomas Lamprecht wrote:
>> just out of interest, could setting a flex+maxHeight for the extra-flags
>> also have been an option?
> 
> AFAICS there is no way to do that. The columns in an inputpanel
> are an 'anchor' layout, and I could not set it so that it would
> take the remaining height of the panel. But theoretically yes,
> if we could make it 'flex' height + a maxHeight for the non wizard case
> this would also work. (possibly with my mentioned rework of the input panel layout)
> 

Ack, sounds like lots of work for not that much benefit, so let's keep
using the simple hacks for now.