public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config
Date: Wed, 7 Jun 2023 19:40:08 +0200	[thread overview]
Message-ID: <134e8fb5-72e2-4aa4-ccfb-e23513bb5c56@proxmox.com> (raw)
In-Reply-To: <20230228105410.51078-2-f.ebner@proxmox.com>

Am 28/02/2023 um 11:54 schrieb Fiona Ebner:
> HA manager currently needs to know about internal details about the
> configs and how the properties are calculated. With this method, those
> details are abstracted away, allowing to change the configuration
> structure. In particular, QemuConfig's 'memory' can be turned into
> a property string without HA manager needing to know about it (once HA
> manager switched to using this mehtod).
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/AbstractConfig.pm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
>

applied, thanks!




  reply	other threads:[~2023-06-07 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 10:54 [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend on internal configuration details Fiona Ebner
2023-02-28 10:54 ` [pve-devel] [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config Fiona Ebner
2023-06-07 17:40   ` Thomas Lamprecht [this message]
2023-02-28 10:54 ` [pve-devel] [PATCH container 1/1] config: implement " Fiona Ebner
2023-06-09  5:50   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH qemu-server " Fiona Ebner
2023-06-08 15:59   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH ha-manager 1/1] resources: pve: avoid relying on internal configuration details Fiona Ebner
2023-06-06  6:42 ` [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=134e8fb5-72e2-4aa4-ccfb-e23513bb5c56@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal