From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager] ui: vm network: allow to override MTU for virtio devices
Date: Fri, 11 Feb 2022 07:29:56 +0000 [thread overview]
Message-ID: <129eaa813d62769d4f1c2bea46992777e5764a02.camel@groupe-cyllene.com> (raw)
In-Reply-To: <20220210143346.1160944-1-o.bektas@proxmox.com>
Note that mtu=1 is a special value, it's inherit from the current
bridge mtu value.
(I don't known if it's possible to add some kind of message in the gui
when this value is choose ?)
Thanks for this patch, It's really usefull for vxlan network.
Le jeudi 10 février 2022 à 15:33 +0100, Oguz Bektas a écrit :
> we already have the 'mtu' option in the API, so we can just expose
> that option inside the 'Advanced' menu for virtio network interfaces.
>
> Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
> Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
> Tested-By: Dylan Whyte <d.whyte@proxmox.com>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v2->v3:
> * use minValue and maxValue for validating the int range (thx aaron)
> * removed the superfluous whitespace lines from v2
>
> and i've added dylan's and aaron's tags from the previous mails as
> well :)
>
> www/manager6/qemu/NetworkEdit.js | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/www/manager6/qemu/NetworkEdit.js
> b/www/manager6/qemu/NetworkEdit.js
> index b39cffdc..3db3a569 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> me.network.macaddr = values.macaddr;
> me.network.disconnect = values.disconnect;
> me.network.queues = values.queues;
> + me.network.mtu = values.mtu;
>
> if (values.rate) {
> me.network.rate = values.rate;
> @@ -33,6 +34,15 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> return params;
> },
>
> + viewModel: {
> + data: {
> + network_model: '',
> + },
> + formulas: {
> + isVirtio: (get) => get('network_model') === 'virtio',
> + },
> + },
> +
> setNetwork: function(confid, data) {
> var me = this;
>
> @@ -112,6 +122,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> 'macaddr',
> 'rate',
> 'queues',
> + 'mtu',
> ];
> fields.forEach(function(fieldname) {
>
> me.down('field[name='+fieldname+']').setDisabled(value);
> @@ -130,6 +141,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> xtype: 'pveNetworkCardSelector',
> name: 'model',
> fieldLabel: gettext('Model'),
> + bind: '{network_model}',
> value: PVE.qemu.OSDefaults.generic.networkCard,
> allowBlank: false,
> },
> @@ -161,6 +173,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> value: '',
> allowBlank: true,
> },
> + {
> + xtype: 'proxmoxintegerfield',
> + name: 'mtu',
> + fieldLabel: 'MTU',
> + value: '',
> + bind: {
> + disabled: '{!isVirtio}',
> + },
> + minValue: 1,
> + maxValue: 65520,
> + allowBlank: true,
> + },
> ];
>
> me.callParent();
next prev parent reply other threads:[~2022-02-11 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 14:33 Oguz Bektas
2022-02-11 7:29 ` DERUMIER, Alexandre [this message]
2022-05-12 12:50 ` Oguz Bektas
2022-05-12 14:24 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129eaa813d62769d4f1c2bea46992777e5764a02.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox