From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2] fix #4358: destroy_vm: Ignore 'suspended' lock when destroying VM
Date: Wed, 11 Jan 2023 11:02:47 +0100 [thread overview]
Message-ID: <1293cc50-ffea-1832-52b0-28f1a0b5a5b6@proxmox.com> (raw)
In-Reply-To: <20230105145156.582258-1-s.hanreich@proxmox.com>
Am 05/01/2023 um 15:51 schrieb Stefan Hanreich:
> Since we can now differentiate between 'suspended' and 'suspending',
> it is possible to ignore the 'suspended' lock when destroying a VM.
> It shouldn't matter whether the VM is locked because of hibernation
> when you want to remove it. Therefore we can safely ignore the lock.
> ---
>
> Changes v1 -> v2:
> * Improved commit message
>
> After thinking about it for awhile, I'm not sure whether showing a
> hint in the UI, when removing a hibernated VM, is that useful. Not sure
> why one would have a reason to reconsider removal suddenly in that
> case. Maybe someone else has some input/ideas on this?
yeah, as said, not a must.
>
> PVE/QemuServer.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-01-11 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 14:51 [pve-devel] " Stefan Hanreich
2023-01-11 10:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293cc50-ffea-1832-52b0-28f1a0b5a5b6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox