[pve-devel] [PATCH manager v2] ui: lxc: set nesting to false for privileged container during creation

[pve-devel] [PATCH manager v2] ui: lxc: set nesting to false for privileged container during creation

[Michael Köppl]

    The current implementation is slightly misleading. When creating a
    privileged container, the nesting checkbox is disabled but keeps its
    current state. However, nesting is not enabled for privileged containers
    even if the checkbox was set to true. With this change, the nesting
    checkbox is set to its unchecked state whenever it is disabled by
    switching to privileged container creation, making clear that the
    nesting feature will not be enabled.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
Changes from v1 to v2:
- Use existing clearOnDisable property instead of data binding and listeners

 www/manager6/lxc/CreateWizard.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 62cda27a..4ec192c0 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -75,6 +75,7 @@ Ext.define('PVE.lxc.CreateWizard', {
 		    name: 'features',
 		    inputValue: 'nesting=1',
 		    value: true,
+		    clearOnDisable: true,
 		    bind: {
 			disabled: '{!unprivileged}',
 		    },
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager v2] ui: lxc: set nesting to false for privileged container during creation

[Thomas Lamprecht]

Am 21.03.25 um 11:35 schrieb Michael Köppl:
>     The current implementation is slightly misleading. When creating a
>     privileged container, the nesting checkbox is disabled but keeps its
>     current state. However, nesting is not enabled for privileged containers
>     even if the checkbox was set to true. With this change, the nesting
>     checkbox is set to its unchecked state whenever it is disabled by
>     switching to privileged container creation, making clear that the
>     nesting feature will not be enabled.

I amended the commit to fix above extra indentation and slightly reword
the subject to clarify that this was not actually set (as in send to the
backend) and that it's now always cleared when disabled, not just if its
disabled due to the privileged checkbox getting ticket like in your v1.
As while that is the only way for the nesting checkbox to be disabled
currently, it's IMO still a bit nicer to avoid suggesting that the new
behavior is limited to the privilege case.
But both are definitively small nits, so just mentioning here for the
sake of completeness.

> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> Changes from v1 to v2:
> - Use existing clearOnDisable property instead of data binding and listeners
> 
>  www/manager6/lxc/CreateWizard.js | 1 +
>  1 file changed, 1 insertion(+)


applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel