From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 manager] ceph install: improve ceph install checks during installation
Date: Tue, 5 Oct 2021 08:08:52 +0200 [thread overview]
Message-ID: <1273bfa9-9782-5961-bf2a-150b4d487bf2@proxmox.com> (raw)
In-Reply-To: <20211004080225.346654-1-a.lauterer@proxmox.com>
On 04.10.21 10:02, Aaron Lauterer wrote:
> Adding a flag file during the Ceph installation helps to cover the time
> span in which the binary is already present but the installation not yet
> done.
>
> The most noticeable effect is that the 'Next' button in the GUI will
> only become active once the installation is actually finished and not
> earlier.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>
> v2 -> v3 (thanks for the hints):
> - calling it a flag and moving it to /run
> - improve file opening / unlinking handling and showing errors
> - adding more / improving comments
>
> v1 -> v3: check for plain file and not just existing file
>
> If the flag file is created before ceph is installed, there is no
> effect. If it is created after Ceph has been installed, the user is
> prompted by the install dialog once more, but apt will be done right
> away.
>
> PVE/CLI/pveceph.pm | 12 ++++++++++++
> PVE/Ceph/Tools.pm | 4 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
>
applied, thanks! I moved the actual file name into a helper method located in
PVE::Ceph::Tools so that there's only a single source of truth for it.
Plus some minor style nits.
prev parent reply other threads:[~2021-10-05 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 8:02 [pve-devel] " Aaron Lauterer
2021-10-05 6:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273bfa9-9782-5961-bf2a-150b4d487bf2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox