Re: [pve-devel] [PATCH firewall 1/1] fix #5335: sort cluster.fw entries in ALIASES section

Re: [pve-devel] [PATCH firewall 1/1] fix #5335: sort cluster.fw entries in ALIASES section

[Fabian Grünbichler]

> Daniel Krambrock via pve-devel <pve-devel@lists.proxmox.com> hat am 11.04.2024 10:09 CEST geschrieben:

Hi!

for both this and the access-control patch, please add
- *some* commit message (e.g., something like "stable sorting in XX config file allows tracking changes by checking into git or when using automation like ansible" would be enough. try to describe the *why*, rather than the *what* - the latter is usually obvious when looking at the diff, especially for such small patches ;))
- add your Signed-off-by trailer ("git commit --amend -s" should do the trick)

note that you don't need to send a cover letter for single patches, those are just needed when you send bigger patch series where it makes sense to summarize all the patches to get a quick overview of the overall aim of the series.

thanks!

> ---
>  src/PVE/Firewall.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
> index 77cbaf4..81a8798 100644
> --- a/src/PVE/Firewall.pm
> +++ b/src/PVE/Firewall.pm
> @@ -3360,7 +3360,7 @@ my $format_aliases = sub {
>      my $raw = '';
>  
>      $raw .= "[ALIASES]\n\n";
> -    foreach my $k (keys %$aliases) {
> +    foreach my $k (sort keys %$aliases) {
>  	my $e = $aliases->{$k};
>  	$raw .= "$e->{name} $e->{cidr}";
>  	$raw .= " # " . encode('utf8', $e->{comment})
> -- 
> 2.39.2