From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH guest-common] replication: avoid "expected snapshot missing warning" when irrelevant
Date: Thu, 22 Sep 2022 13:13:03 +0200 [thread overview]
Message-ID: <11872ccc-87bf-1b9b-e884-285018f93c78@proxmox.com> (raw)
In-Reply-To: <20220922110023.115994-1-f.ebner@proxmox.com>
Am 22.09.22 um 13:00 schrieb Fiona Ebner:
> Namely, when there are no snapshots at all on the volume, which also
> is the case when the volume doesn't exist. This happens when a fresh
> volume is added to an already replicated guest.
The warning still triggers, when some other snapshot is added to the new
disk before the replication runs (by taking a snapshot or via another
replication). I'll send a v2 and print the warning only when there's
actually another replication snapshot that would've been removed without
the safeguard added by c0b2948.
>
> Fixes replication tests in pve-manager, which didn't like the additional
> output.
>
> Fixes: c0b2948 ("replication: prepare: safeguard against removal if expected snapshot is missing")
prev parent reply other threads:[~2022-09-22 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 11:00 Fiona Ebner
2022-09-22 11:13 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11872ccc-87bf-1b9b-e884-285018f93c78@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox