public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v2 3/3] ui: qemu hd edit: allow importing a disk from the import storage
Date: Tue, 25 Mar 2025 12:10:17 +0100	[thread overview]
Message-ID: <1161ac7b-1c06-4192-851e-eb9e10481c4d@proxmox.com> (raw)
In-Reply-To: <20250320134010.2959253-5-d.csapak@proxmox.com>

The bug from before is solved, but instead a different bug has appeared:
When I enable the "Import Image" checkbox on the "Disks" tab of the
virtual machine creation wizard, the "Select Image" selector is disabled
by default. It can be enabled by switching the import storage.

On 20/03/2025 14:40, Dominik Csapak wrote:
> + fieldLabel: gettext("Import Image"),
> + listeners: {
> + change: function(_cb, value) {
> + me.lookup('new-disk').setVisible(!value);
> + me.lookup('new-disk').setDisabled(!!value);
> +
> + me.lookup('import-source').setVisible(!!value);
> + me.lookup('import-source').setDisabled(!value);
> + me.lookup('import-source-file').setVisible(!!value);
> +
> + me.lookup('import-target').setVisible(!!value);
> + me.lookup('import-target').setDisabled(!value);
> + },

It seems this can be fixed by adding:

me.lookup('import-source-file').setDisabled(!value);



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-25 11:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 13:40 [pve-devel] [PATCH storage/manager v2] allow upload & import of qcow2 in the web UI Dominik Csapak
2025-03-20 13:40 ` [pve-devel] [PATCH storage v2 1/1] import: allow upload of qcow2 files into import storage Dominik Csapak
2025-03-20 13:40 ` [pve-devel] [PATCH manager v2 1/3] ui: storage content: allow upload of qcow2 for import type Dominik Csapak
2025-03-20 13:40 ` [pve-devel] [PATCH manager v2 2/3] ui: form: file selector: allow optional filter Dominik Csapak
2025-03-20 13:40 ` [pve-devel] [PATCH manager v2 3/3] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
2025-03-25 11:10   ` Filip Schauer [this message]
2025-03-25 15:16 ` [pve-devel] [PATCH storage/manager v2] allow upload & import of qcow2 in the web UI Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1161ac7b-1c06-4192-851e-eb9e10481c4d@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal