From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] install: ask for patience when making system bootable
Date: Fri, 15 Nov 2024 14:45:55 +0100 (CET) [thread overview]
Message-ID: <1145434497.4741.1731678355144@webmail.proxmox.com> (raw)
In-Reply-To: <efe3ec7f-1afe-4ed9-98d6-ae21a51a9d7a@proxmox.com>
> On 15.11.2024 14:35 CET Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
>
>
> Am 15.11.24 um 13:43 schrieb Christian Ebner:
> > Making the system bootable can take some time if many disks are used
> > for installation, which could be misinterpreted as a hanging
> > installer. Add a please be patient output when more than 3 disks are
> > used.
> >
> > Output changes from `make system bootable` to
> > `make system bootable (please be patient)`
>
> What about including the reason for the need to be patient, like e.g.:
>
> make system bootable (multiple disks detected, please be patient)
Even better, I didn't want to make it to long though.
>
>
> If you agree, or even have a better proposal for wording it, I can also
> squash this in when applying your patch.
Agreed, please feel free to squash in the additional reasoning!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-15 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 12:43 Christian Ebner
2024-11-15 13:35 ` Thomas Lamprecht
2024-11-15 13:45 ` Christian Ebner [this message]
2024-11-15 14:33 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145434497.4741.1731678355144@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox