From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES qemu-server] avoid cyclic use of main module in memory module
Date: Mon, 18 Sep 2023 17:12:15 +0200 [thread overview]
Message-ID: <1143a379-7c97-46a3-a20d-a0e135d14e0f@proxmox.com> (raw)
In-Reply-To: <20230904113949.940431-1-f.ebner@proxmox.com>
Am 04/09/2023 um 13:39 schrieb Fiona Ebner:
> Mostly cleanup, moving some code out of the main module and as
> indirect preparation for Alexandre's series reworking memory hotplug
> [0]. At one point during development, the cyclic use caused actual
> problems [1]. Let's avoid any future surprises caused by the cyclic
> use and get rid of it.
>
> Also includes the first patch of Alexandre's series, because that
> gets rid of the PVE::QemuServer::defaults() call.
>
> Because of that patch a versioned Breaks for pve-ha-manager < 4.0.1 is
> needed, because earlier versions don't expect a property string.
>
> [0]: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057690.html
> [1]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055356.html
>
>
> Alexandre Derumier (1):
> add memory parser
>
> Fiona Ebner (4):
> move parse_number_sets() helper to helpers module
> move NUMA-related code into memory module
> memory: replace deprecated check_running() call
> introduce QMPHelpers module
>
> PVE/API2/Qemu.pm | 7 +-
> PVE/QemuConfig.pm | 8 +-
> PVE/QemuMigrate.pm | 6 +-
> PVE/QemuServer.pm | 123 +++++--------------------------
> PVE/QemuServer/Helpers.pm | 18 ++++-
> PVE/QemuServer/Makefile | 1 +
> PVE/QemuServer/Memory.pm | 138 +++++++++++++++++++++++++++++------
> PVE/QemuServer/QMPHelpers.pm | 48 ++++++++++++
> 8 files changed, 208 insertions(+), 141 deletions(-)
> create mode 100644 PVE/QemuServer/QMPHelpers.pm
>
applied series, thanks!
prev parent reply other threads:[~2023-09-18 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 11:39 [pve-devel] " Fiona Ebner
2023-09-04 11:39 ` [pve-devel] [PATCH qemu-server 1/5] move parse_number_sets() helper to helpers module Fiona Ebner
2023-09-04 11:39 ` [pve-devel] [PATCH qemu-server 2/5] move NUMA-related code into memory module Fiona Ebner
2023-09-04 11:39 ` [pve-devel] [PATCH qemu-server 3/5] memory: replace deprecated check_running() call Fiona Ebner
2023-09-04 11:39 ` [pve-devel] [PATCH qemu-server 4/5] introduce QMPHelpers module Fiona Ebner
2023-09-04 11:39 ` [pve-devel] [PATCH qemu-server 5/5] add memory parser Fiona Ebner
2023-09-18 15:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143a379-7c97-46a3-a20d-a0e135d14e0f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox