From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Mon, 7 Jul 2025 12:53:16 +0200 (CEST) [thread overview]
Message-ID: <1109363863.2769.1751885596032@webmail.proxmox.com> (raw)
In-Reply-To: <c671fe82a7cdab90a3691115a7132d0a35ae79b7.camel@groupe-cyllene.com>
> DERUMIER, Alexandre <alexandre.derumier@groupe-cyllene.com> hat am 07.07.2025 12:18 CEST geschrieben:
> >>for the DirPlugin we need to add another level for the snapshots
> >>on-disk, else we cannot differentiate between weirdly-named image
> >>files and snapshot files..
> >>
> >>so we could add a directory "snapshots" and put all the snapshot
> >>files in there. since snapshots are never references a volume ID,
> >>this just affects the on disk structure, not the volume ID format.
>
> ok, no problem, I'll do it like this.
>
> Do you want the a snapshot sub directory like ?
> /var/lib/vz/images/<vmid>/snapshots/
I think this makes the most sense, as it logically groups the snapshot
files below the main ones..
>
> or a global snapshots like
>
> /var/lib/vz/snapshots/<vmid>/
>
> ?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-07 10:52 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com>
2025-07-04 6:44 ` [pve-devel] [PATCH qemu-server 1/3] qemu_img convert : " Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 01/10] tests: add lvmplugin test Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH qemu-server 2/3] blockdev: add backing_chain support Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 02/10] common: add qemu_img_create an preallocation_cmd_option Alexandre Derumier via pve-devel
2025-07-04 11:53 ` Fabian Grünbichler
2025-07-04 12:33 ` DERUMIER, Alexandre via pve-devel
[not found] ` <51f988f11e60f9dfaa49658c1ed9ecf72fcfcde4.camel@groupe-cyllene.com>
2025-07-07 7:55 ` Fabian Grünbichler
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 03/10] common: qemu_img_create: add backing_file support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:31 ` DERUMIER, Alexandre via pve-devel
2025-07-07 7:16 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH qemu-server 3/3] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:46 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 04/10] rename_volume: add source && target snap Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:04 ` Thomas Lamprecht
2025-07-07 10:34 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 05/10] common: add qemu_img_info helper Alexandre Derumier via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 06/10] common: add qemu-img measure Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 07/10] storage: volume_snapshot: add $running param Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 13:22 ` DERUMIER, Alexandre via pve-devel
[not found] ` <c38598bae6477dfa6af0db96da054b156698d41c.camel@groupe-cyllene.com>
2025-07-07 8:17 ` Fabian Grünbichler
2025-07-07 10:18 ` DERUMIER, Alexandre via pve-devel
[not found] ` <c671fe82a7cdab90a3691115a7132d0a35ae79b7.camel@groupe-cyllene.com>
2025-07-07 10:53 ` Fabian Grünbichler [this message]
2025-07-08 8:44 ` DERUMIER, Alexandre via pve-devel
[not found] ` <3d1d8516e3c68de370608033647a38e99ef50f23.camel@groupe-cyllene.com>
2025-07-08 8:56 ` Fabian Grünbichler
2025-07-08 11:37 ` DERUMIER, Alexandre via pve-devel
2025-07-08 10:04 ` DERUMIER, Alexandre via pve-devel
[not found] ` <27854af70a4fe3a7765d2760098e2f82f3475f17.camel@groupe-cyllene.com>
2025-07-08 10:59 ` Fabian Grünbichler
2025-07-08 11:35 ` DERUMIER, Alexandre via pve-devel
[not found] ` <0b2ba0c34d2c8c15d7cb642442b300a3180e1592.camel@groupe-cyllene.com>
2025-07-08 12:50 ` Thomas Lamprecht
2025-07-08 13:19 ` DERUMIER, Alexandre via pve-devel
2025-07-08 13:42 ` DERUMIER, Alexandre via pve-devel
[not found] ` <67627e7904281520e1f7152657ed00c7ba3c138b.camel@groupe-cyllene.com>
2025-07-08 14:18 ` Fabian Grünbichler
2025-07-09 12:52 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
2025-07-09 7:24 ` DERUMIER, Alexandre via pve-devel
2025-07-09 8:06 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109363863.2769.1751885596032@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox