Re: [pve-devel] [PATCH storage 4/5] lvm plugin: use relative path for qcow2 rebase command

[Fiona Ebner <f.ebner@proxmox.com>]

Am 29.07.25 um 9:39 AM schrieb Fabian Grünbichler:
> otherwise the resulting qcow2 file will contain an absolute path, which makes
> renaming the backing VG of the storage impossible.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

with a nit below:

> ---
>  src/PVE/Storage/LVMPlugin.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index db1be98..9a04db6 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -1120,12 +1120,13 @@ sub volume_snapshot_delete {
>          my $parentpath = $snapshots->{$parentsnap}->{file};

This variable is unused now and could be removed like in the previous patch.

>          print
>              "$volname: deleting snapshot '$snap' by rebasing '$childsnap' on top of '$parentsnap'\n";
> -        print "running 'qemu-img rebase -b $parentpath -F qcow2 -f qcow2 $childpath'\n";
> +        my $rel_parent_path = get_snap_name($class, $volname, $parentsnap);
> +        print "running 'qemu-img rebase -b $rel_parent_path -F qcow2 -f qcow2 $childpath'\n";
>          $cmd = [
>              '/usr/bin/qemu-img',
>              'rebase',
>              '-b',
> -            $parentpath,
> +            $rel_parent_path,
>              '-F',
>              'qcow2',
>              '-f',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel