public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager] ha-simulator: add xauth dependency
Date: Mon, 1 Feb 2021 11:46:04 +0100	[thread overview]
Message-ID: <103788e5-420a-f241-6a23-e7b063d402c8@proxmox.com> (raw)
In-Reply-To: <20210201101844.15520-1-a.lauterer@proxmox.com>

On 01.02.21 11:18, Aaron Lauterer wrote:
> The xauth package is needed for the example in the docs to access the
> ha-simulator via ssh with x11 forwarding.

then the client needs it, and the client does not installs the ha-sim
if it's used over ssh anyway?

Even if required for the server side in that case it'd be only a Suggests
or at max a Recommends, but no hard-dependency (could especially become
a problem with some pure wayland setups in the future)

> 
> On systems with a desktop environment the xauth package is usually
> already installed, but on a clean PVE installation it is missing.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> I am not sure if there is more needed from my side for this patch. If
> so, let me know.
> 
>  debian/control | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/control b/debian/control
> index 7b4ffb0..62eb4e9 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -46,6 +46,7 @@ Depends: libclone-perl,
>           libnet-ip-perl,
>           libstring-shellquote-perl,
>           liburi-perl,
> +         xauth,
>           ${misc:Depends},
>           ${perl:Depends},
>  Description: Proxmox VE HA Simulator
> 





      reply	other threads:[~2021-02-01 10:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:18 Aaron Lauterer
2021-02-01 10:46 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=103788e5-420a-f241-6a23-e7b063d402c8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal